[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #11 from Isarra zhoris...@gmail.com --- Aye, treating longer ones as indefinite would probably be sensible in general, but it wouldn't necessarily resolve the other problems. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com --- Comment #8 from Bartosz Dziewoński matma@gmail.com --- (In reply to comment #7) (In reply to comment #4) There seem to be two major issues here: that these blocks of unusual times are failing, and also that the confirmation message and logs are still showing them as successful even when they do fail. There's a third major issue, I think: why doesn't MediaWiki simply reject these plainly retarded expiry inputs? The issue is that it does. It uses strtotime() to parse them, and it returns a non-error value for both 10 years (on 64-bit systems, apparently) and a potato (don't ask me why). It should probably check for values over the database 'int' type capacity and earlier than today. But this bug covers that. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #9 from MZMcBride b...@mzmcbride.com --- (In reply to comment #8) It should probably check for values over the database 'int' type capacity and earlier than today. But this bug covers that. Not just 'int' capacity: if you attempt to block someone for longer than, say, 200 years, it should either convert to indefinite to be flatly rejected. The software can be a bit smarter here. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #10 from MZMcBride b...@mzmcbride.com --- s/to be/or be/ I'm still waking up. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #7 from MZMcBride b...@mzmcbride.com --- (In reply to comment #4) There seem to be two major issues here: that these blocks of unusual times are failing, and also that the confirmation message and logs are still showing them as successful even when they do fail. There's a third major issue, I think: why doesn't MediaWiki simply reject these plainly retarded expiry inputs? The correct answer to trying to block a user for a duration of 100,000 years or a potato or whatever is to simply reject the request. Is there an open bug about this? If not, can you open one, please? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #5 from Addshore addshorew...@gmail.com --- Well it turns out that I can not really test this / fix it on my system as my system currently uses 32 bit signed int which limits my timestamp to 2038-01-19 03:14:07 which I imagine is why my tests show the blocks stopping at a lower value. I would say a similar thing is causing the reported issue but the limit for 64bit signed ints / timestamps is 293 billion years ish -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #6 from Alex Monk kren...@gmail.com --- (In reply to comment #5) Well it turns out that I can not really test this / fix it on my system as my system currently uses 32 bit signed int which limits my timestamp to 2038-01-19 03:14:07 which I imagine is why my tests show the blocks stopping at a lower value. I would say a similar thing is causing the reported issue but the limit for 64bit signed ints / timestamps is 293 billion years ish I think that's https://en.wikipedia.org/wiki/Year_2038_problem :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #3 from Addshore addshorew...@gmail.com --- I have tested this on a local instance and I get the same results with much lower block values, here is what I have found. In the DB a timestamp of 20380119021407 and 20380119021408 are displayed on Special:Blocklist as very different datetimes (even though there is only a second difference). One displays as 1970, one displays as 2038.. As far as I can tell I have traced this back to useradjust around line 1881 in languages/language.php where $date returns incorrectly. And again as far as I can tell this is due to mktime in this function (toward the bottom) occasionally returning a null value therefor returning the block expiry as the Unix epoch which has passed which Block::purgeExpired then removes from the db as an expired block. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #1 from Addshore addshorew...@gmail.com --- 31 millennia, 6 centuries, 8 decades, 8 years, 269 days, 17 hours, 37 minutes and 3 seconds ( seconds) also fails to actually block the user but will create a log entry. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Lowest Version|unspecified |1.22-git Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49580] blocking for 100000 years doesn't create a block but fills block log
https://bugzilla.wikimedia.org/show_bug.cgi?id=49580 --- Comment #2 from Alex Monk (Krenair) kren...@gmail.com --- Looking at the debug toolbar, a block is created, but doesn't even last to the end of the success page load - It's inserted with ipb_expiry = '', but then Block::purgeExpired kills all such blocks (DELETE FROM `ipblocks` WHERE (ipb_expiry '20130614203608'), and a blank string is always smaller than another string). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
