[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #29 from Andre Klapper  ---
Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Jan Zerebecki  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 CC||jan.wikime...@zerebecki.de
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #28 from Daniel Zahn  ---
https://gerrit.wikimedia.org/r/#/c/144855/2/template/en/custom/global/header.html.tmpl
  - deployed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Daniel Zahn  changed:

   What|Removed |Added

 CC||dz...@wikimedia.org

--- Comment #27 from Daniel Zahn  ---
we are now loading the required Apache modules:

expires.load -> ../mods-available/expires.load
headers.load -> ../mods-available/headers.load
env.load -> ../mods-available/env.load

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #26 from Gerrit Notification Bot  ---
Change 127254 merged by Dzahn:
bugzilla apache: Enable required modules for caching

https://gerrit.wikimedia.org/r/127254

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #25 from Gerrit Notification Bot  ---
Change 127254 had a related patch set uploaded by Krinkle:
bugzilla apache: Enable required modules for caching

https://gerrit.wikimedia.org/r/127254

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Bug 49720 depends on bug 49792, which changed state.

Bug 49792 Summary: Bugzilla: Send a Last-Modified header for css/js
https://bugzilla.wikimedia.org/show_bug.cgi?id=49792

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Andre Klapper  changed:

   What|Removed |Added

   Priority|High|Normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Sam Reed (reedy)  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #24 from Andre Klapper  ---
Still same problem on zirconium (new server that will replace kaulen).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #23 from Andre Klapper  ---
Ahem, while digesting the 4.4 release notes, I ran into
http://www.bugzilla.org/releases/4.0/release-notes.html#v40_feat_js_css_update
:
   mod_headers
   mod_expires
   mod_env
need to be installed.

Running /srv/org/wikimedia/bugzilla/checksetup.pl on kaulen should tell us.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #22 from MZMcBride  ---
Ori found the Apache config for Bugzilla. .htaccess is enabled:
.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #21 from MZMcBride  ---
(In reply to comment #20)
> So much for that theory. :(
> Revision 8748 of http://bzr.mozilla.org/bugzilla/trunk/view/head:/.htaccess
> is
> nearly the same as our .htaccess and we have
>   SetEnv BZ_CACHE_CONTROL 1
> set.

What do you mean by "our .htaccess"? Most Wikimedia Apache servers are
configured to ignore .htaccess files, I believe, as enabling .htaccess support
is a performance hit. Are you sure this file is being used?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #20 from Andre Klapper  ---
So much for that theory. :(
Revision 8748 of http://bzr.mozilla.org/bugzilla/trunk/view/head:/.htaccess is
nearly the same as our .htaccess and we have
  SetEnv BZ_CACHE_CONTROL 1
set. Only difference in upstream is an additional
  
RewriteEngine On
RewriteRule ^rest/(.*)$ rest.cgi/$1 [NE]
  
at the end.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Andre Klapper  changed:

   What|Removed |Added

   Priority|Lowest  |High

--- Comment #19 from Andre Klapper  ---
Thanks for the help! Looking at .htaccess was also my guess after reading
http://bzr.mozilla.org/bugzilla/trunk/revision/7391

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #18 from Ori Livneh  ---
I meant to link to the mtime implementation, too:
http://lxr.mozilla.org/bugzilla/source/Bugzilla/Template.pm#412

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #17 from Ori Livneh  ---
The cache-busting timestamp is affixed to the URL by the 'mtime' filter:

http://git.wikimedia.org/blob/wikimedia%2Fbugzilla%2Fmodifications.git/eee3bdc9f86d8a7dc8dad5ef907f1818f1fe71ac/template%2Fen%2Fcustom%2Fglobal%2Fheader.html.tmpl#L120

If you look up the implementation of 'mtime', it appears to check for the
existence of a 'BZ_CACHE_CONTROL' environment variable. When it is set, the
timestamp is affixed; when it is not set, 'mtime' does nothing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #16 from Andre Klapper  ---
Looking at boogs.wmflabs.org I can see

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Andre Klapper  changed:

   What|Removed |Added

   Priority|Normal  |Lowest

--- Comment #15 from Andre Klapper  ---
I don't plan to work on this -> Setting lowest priority.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Ori Livneh  changed:

   What|Removed |Added

 CC||o...@wikimedia.org

--- Comment #14 from Ori Livneh  ---
Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=428313

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

--- Comment #13 from Matthew Flaschen  ---
If you mean http://stackoverflow.com/a/119326/ ("According the letter of the
HTTP caching specification, user agents should never cache URLs with query
strings. While Internet Explorer and Firefox ignore this, Opera and Safari
don’t"), that apparently isn't accurate (http://stackoverflow.com/a/85386/). 
However, if we wanted to be on the safe side we could use directories and a
rewrite rule.  Something like:

/static/mtime/file.css

rewritten to:

/static/file.css

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Matthew Flaschen  changed:

   What|Removed |Added

 CC||mflasc...@wikimedia.org

--- Comment #12 from Matthew Flaschen  ---
(In reply to comment #11)
> I have basically no clue about this, and if I interpret
> http://stackoverflow.com/questions/118884/what-is-an-elegant-way-to-force-
> browsers-to-reload-cached-css-js-files
> correctly and if I consider the information trustworthy, then adding a query
> parameter is not a great idea.

Which answer are you referring to?

There's lots of ways to do this, some elaborate, some simple.  A simple way is
to include a querystring containing the file's modification time or hash in the
static (CSS/JS) references.  Then, whenever the HTML is generated, it will
generate URLs uniquely identifying the current static content.  This allows the
static content to be cached for a long time (since changing the querystring
changes the URL).

MW's ResourceLoader takes the modification time approach (though it has a lot
of other functionality)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 49720] Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=49720

Andre Klapper  changed:

   What|Removed |Added

Summary|Bugzilla: Add a query   |Bugzilla: Add a query
   |parameter to CSS URL|parameter to CSS URL to
   ||force browsers to reload
   ||cached CSS files

--- Comment #11 from Andre Klapper  ---
I have basically no clue about this, and if I interpret
http://stackoverflow.com/questions/118884/what-is-an-elegant-way-to-force-browsers-to-reload-cached-css-js-files
correctly and if I consider the information trustworthy, then adding a query
parameter is not a great idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l