[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #11 from C. Scott Ananian canan...@wikimedia.org --- Hm, maybe this only occurs with images from commons now? Can you confirm that, James? It would be helpful to see exactly what VE is giving to Parsoid for new images, and how you

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added Blocks||54844 --

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #12 from C. Scott Ananian canan...@wikimedia.org --- Hm, I note that the DOM spec describes resource attribute on image this way: link to image resource page. TODO: what to use for images from commons? I'm guessing this is the

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #13 from C. Scott Ananian canan...@wikimedia.org --- Ok, from looking at the code I can confirm that the link= attribute should be suppressed iff the img[resource] attribute is equal to the a[href]. I'm guessing that autocommons is

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #14 from C. Scott Ananian canan...@wikimedia.org --- mooeypoo and I tried to reproduce without success. the code looks correct: the link option is suppressed iff a[href] == img[resource]. Both of these should be local relative

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added Status|REOPENED|RESOLVED

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 119087 had a related patch set uploaded by Cscott: Clarified the default link for image insertion. https://gerrit.wikimedia.org/r/119087 -- You are receiving

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|RESOLVED

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 119087 merged by jenkins-bot: Clarified the default link for image insertion. https://gerrit.wikimedia.org/r/119087 -- You are receiving this mail because: You

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #8 from C. Scott Ananian canan...@wikimedia.org --- This should be fixed by https://gerrit.wikimedia.org/r/103082 (if it wasn't already fixed). Should be verified fixed by the VE team once this lands (and their local workaround

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added CC|

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Component|JS/General |General ---

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Priority|High|Normal -- You

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/70551 (Gerrit Change I75dbbfdd248a6f5696252ef3a2d7ca6ede0fa156) -- You are receiving this mail because: You are on the CC

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 James Forrester jforres...@wikimedia.org changed: What|Removed |Added CC|

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 --- Comment #5 from James Forrester jforres...@wikimedia.org --- This is worked around (albeit with potentially a bit of a hack) in VisualEditor, so not so important now from VisualEditor's POV. -- You are receiving this mail because: You are

[Bug 49844] Images: New images get a link=… set whether or not they need it

https://bugzilla.wikimedia.org/show_bug.cgi?id=49844 ssas...@wikimedia.org changed: What|Removed |Added Summary|Parsoid: New images get a |Images: New images get a