https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 105164 merged by jenkins-bot:
Removed the details link if the user is already in details page
https://gerrit.wikimedia.org/r/105164
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
Tony Thomas 01tonytho...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 105164 had a related patch set uploaded by 01tonythomas:
Removed the details link if the user is already in details page
https://gerrit.wikimedia.org/r/105164
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #6 from sakshi.apr...@gmail.com ---
Well while trying to fix the bug, I was not sure if this is the correst patch
or not. Hence I decided to just commment the line and not remove it completely
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #7 from Nischay Nahata nischay...@gmail.com ---
Ok. As Andre said please try using Git and Gerrit to submit a patch. It will be
reviewed there so you can remove it if needed.
--
You are receiving this mail because:
You are on the
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #8 from sakshi.apr...@gmail.com ---
Well I tried to work with Git and Gerrit to submit the patch.
But I am unable to submit a patch.
$git review -R
ssh: connect to host gerrit.wikimedia.org port 29418: Connection timed out
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #9 from Andre Klapper aklap...@wikimedia.org ---
Might be bug 56034 comment 8 - might work after a few times of re-trying.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #10 from sakshi.apr...@gmail.com ---
Well I tried it a few times.
In the main directory there exists a .git/ directory and .gitreview file, but
still git review -R does not work.
--
You are receiving this mail because:
You are on
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
sakshi.apr...@gmail.com changed:
What|Removed |Added
CC||sakshi.apr...@gmail.com
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Assignee|wikibugs-l@lists.wikimedia.
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #3 from sakshi.apr...@gmail.com ---
Created attachment 13612
-- https://bugzilla.wikimedia.org/attachment.cgi?id=13612action=edit
I have commented the line so that the actionLinks does not have the
detailsLink.
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Keywords||patch,
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
--- Comment #5 from Nischay Nahata nischay...@gmail.com ---
Why comment and not remove the line entirely if its not required?
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=50808
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Priority|Unprioritized |Low
15 matches
Mail list logo
