[Bug 52292] Changing the commit description creates out-dated patch.
https://bugzilla.wikimedia.org/show_bug.cgi?id=52292 --- Comment #5 from Sorawee Porncharoenwase --- I ran into the exactly same problem on gerrit: 111943. It's so annoying. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52292] Changing the commit description creates out-dated patch.
https://bugzilla.wikimedia.org/show_bug.cgi?id=52292 Bartosz Dziewoński changed: What|Removed |Added CC||aricha...@wikimedia.org --- Comment #4 from Bartosz Dziewoński --- *** Bug 59892 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52292] Changing the commit description creates out-dated patch.
https://bugzilla.wikimedia.org/show_bug.cgi?id=52292 --- Comment #3 from Marcin Cieślak --- No, not necessary. Our last patchset is patch set 5 which is revision bbb123 based on parent aaa456 One developer submitted patch set 6 (revision ccc789) based on the parent revision aaa456 as well. Then another developer edits something which means submitting independent patch set 7 based on the parent revision aaa456 as well. It can include stuff from patchset 5 but does not have to. All patchsets are independent "children" of the parent. Sometimes parents differ when you "rebase" your stuff. One can squash (merge) few changes into one - I would checkout patch set 6 and then checkout patch set 7 by using "git cherry-pick -n" without using another commit. You can use "git-review -X change,patchnr" for that. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52292] Changing the commit description creates out-dated patch.
https://bugzilla.wikimedia.org/show_bug.cgi?id=52292 --- Comment #2 from Tyler Romeo --- How is that expected? It'd be like committing a database transaction where the data has changed since it was last read, or a more appropriate example: having a edit conflict on Wikipedia be resolved just by overwriting the last revision. The correct behavior would be to display an error saying there was an edit conflict. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52292] Changing the commit description creates out-dated patch.
https://bugzilla.wikimedia.org/show_bug.cgi?id=52292 --- Comment #1 from christ...@quelltextlich.at --- Mhmmm. As your browser window was still at patch set 5, it looks like expected behaviour to me. I would not want gerrit to second guess the one who edited the commit message of patch set 5 or even forbid editing the commit message in that case. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
