[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 --- Comment #19 from Yuvi Panda yuvipa...@gmail.com --- Should I WONTFIX this? Or leave it open for some other brave soul? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Normal |Low -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 --- Comment #18 from Yuvi Panda yuvipa...@gmail.com 2011-11-10 18:38:58 UTC --- @Sumana: I think consensus when this was 'abandoned' was that this was a third-hand patch (someone wrote it originally, I just cleaned it up, and then someone else would have to review/commit this). And that made it too untrustworthy/fragile in terms of quality to be accepted. I doubt that has changed? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords|need-review |reviewed CC||suma...@panix.com AssignedTo|br...@wikimedia.org |wikibugs-l@lists.wikimedia. ||org --- Comment #17 from Sumana Harihareswara suma...@panix.com 2011-11-06 14:13:08 UTC --- Yuvi, I'm sorry no one reviewed your patch in the last several months. Sadly, it no longer applies cleanly to trunk. Do you possibly have time to update it? Since you now have commit access, you could just commit your updated patch into SVN. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Yuvi Panda yuvipa...@gmail.com changed: What|Removed |Added Attachment #8343|0 |1 is obsolete|| --- Comment #16 from Yuvi Panda yuvipa...@gmail.com 2011-03-30 21:27:21 UTC --- Created attachment 8353 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8353 Patch to fix issues mentioned in CR Re-added Brion's copyright header, as per Reedy's suggestion. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Yuvi Panda yuvipa...@gmail.com changed: What|Removed |Added Attachment #8325|0 |1 is obsolete|| Attachment #8326|0 |1 is obsolete|| --- Comment #14 from Yuvi Panda yuvipa...@gmail.com 2011-03-28 21:25:34 UTC --- Created attachment 8342 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8342 Patch to fix issues mentioned in CR Fixes issues mentioned in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84706 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Yuvi Panda yuvipa...@gmail.com changed: What|Removed |Added Attachment #8342|0 |1 is obsolete|| --- Comment #15 from Yuvi Panda yuvipa...@gmail.com 2011-03-28 21:35:33 UTC --- Created attachment 8343 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8343 Patch to fix issues mentioned in CR Forgot to add documentation in previous patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Happy-melon happy.melon.w...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #13 from Happy-melon happy.melon.w...@gmail.com 2011-03-27 12:23:53 UTC --- Reverted in r84842, throws enormous numbers of E_STRICT errors on TranslateWiki. Please see comments on CodeReview for r84706 and r84709. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Yuvi Panda yuvipa...@gmail.com changed: What|Removed |Added Attachment #8300|0 |1 is obsolete|| Attachment #8308|0 |1 is obsolete|| --- Comment #10 from Yuvi Panda yuvipa...@gmail.com 2011-03-24 19:14:33 UTC --- Created attachment 8325 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8325 Patch with all defines moved to UtfNormalDefines.php Removed a bunch of warnings. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 --- Comment #11 from Yuvi Panda yuvipa...@gmail.com 2011-03-24 20:26:43 UTC --- Created attachment 8326 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8326 Clean Patch, without generated files. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Happy-melon happy.melon.w...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||happy.melon.w...@gmail.com Resolution||FIXED --- Comment #12 from Happy-melon happy.melon.w...@gmail.com 2011-03-24 20:53:23 UTC --- Patch applied in r84706. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 --- Comment #8 from Yuvi Panda yuvipa...@gmail.com 2011-03-23 20:12:50 UTC --- apergos (Ariel) ran two medium sized dumps (~5 hours on wmf clusters) and found a ~3% performance improvement with the new UtfNormal. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 --- Comment #9 from Yuvi Panda yuvipa...@gmail.com 2011-03-24 05:27:42 UTC --- Testing without php5-intl on a smallish dump (~30 revs) gives around 8.5x improvement. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 --- Comment #7 from Yuvi Panda yuvipa...@gmail.com 2011-03-17 19:01:06 UTC --- Created attachment 8308 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8308 Smaller, Cleaner Partial Diff Apply, then copy https://bugzilla.wikimedia.org/attachment.cgi?id=1456 and https://bugzilla.wikimedia.org/attachment.cgi?id=1455 to includes/normal. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Yuvi Panda yuvipa...@gmail.com changed: What|Removed |Added CC||yuvipa...@gmail.com --- Comment #4 from Yuvi Panda yuvipa...@gmail.com 2011-03-16 18:41:56 UTC --- This code still works (with very minor modifications). I've attached a patch that should apply cleanly on the 1.17 branch (and most probably on trunk too). The claim of ~5% improvement in time also still checks out (I didn't check with the php extension disabled though). Crude kcachegrind screenshots of a profiled run of dumpBackup.php with and without the patch here[1]. make test passes. [1]: http://imgur.com/jxDxXfVF35l -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Yuvi Panda yuvipa...@gmail.com changed: What|Removed |Added Attachment #1455|0 |1 is obsolete|| Attachment #1456|0 |1 is obsolete|| --- Comment #5 from Yuvi Panda yuvipa...@gmail.com 2011-03-16 18:43:43 UTC --- Created attachment 8300 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8300 Patch to make it apply cleanly 5 years after original was written -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 --- Comment #6 from Yuvi Panda yuvipa...@gmail.com 2011-03-16 18:47:51 UTC --- Comment on attachment 8300 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8300 Patch to make it apply cleanly 5 years after original was written Contains the autogenerated data file as well. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5303] UtfNormal replacement proposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=5303 Brion Vibber br...@wikimedia.org changed: What|Removed |Added CC||br...@wikimedia.org AssignedTo|wikibugs- |br...@wikimedia.org |l...@lists.wikimedia.org | --- Comment #3 from Brion Vibber br...@wikimedia.org 2008-12-16 01:52:27 UTC --- Lost in the mists of time. :( Will take another look over this! :D -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
