[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 119350 had a related patch set uploaded by Nemo bis: Show an error message when no or invalid parameters are passed to thumb.php https://gerrit.wikimedia.org/r/119350 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 --- Comment #6 from Rahul Mishra priyrahulmis...@gmail.com --- Created attachment 14846 -- https://bugzilla.wikimedia.org/attachment.cgi?id=14846action=edit thumb.php should output docs if no file specified. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 --- Comment #7 from Tony Thomas 01tonytho...@gmail.com --- (In reply to Rahul Mishra from comment #6) Created attachment 14846 [details] Great!This one really looks like a patch. Why dont you push the same into gerrit? I have added the how-to in Comment#4 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 --- Comment #8 from Rahul Mishra priyrahulmis...@gmail.com --- (In reply to Tony Thomas from comment #7) Created attachment 14846 [details] I have added the how-to in Comment#4 Thanks, for your comment, i was having some problem with my gerrit account, will ask on #mediawiki and fix it as fast as possible. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 Rahul Mishra priyrahulmis...@gmail.com changed: What|Removed |Added CC||priyrahulmis...@gmail.com --- Comment #3 from Rahul Mishra priyrahulmis...@gmail.com --- I have tried to fix it, would you take a look at it Proposed Patch: http://fpaste.org/85648/94892293/ (the additions are between line 111 to line 118) Please let me know, if i have understood it correctly and if the patch i working as it should. If not, what do i have to do to fix it. Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 --- Comment #4 from Tony Thomas 01tonytho...@gmail.com --- (In reply to Rahul Mishra from comment #3) I have tried to fix it, would you take a look at it Thanks for your fix. But, your patch doesn't seem to be in a diff/patch format. When referring to a patch, its always helpful if you can make it in the std. diff format. You can check here, how to create a diff/patch using git diff command (http://git-scm.com/docs/git-diff). Try to prepare a gerrit patch set so that its easy for other devs to test your code, and debug. http://www.mediawiki.org/wiki/Gerrit/Tutorial -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118822 had a related patch set uploaded by Santosh2201: thumb.php should output docs if no file specified https://gerrit.wikimedia.org/r/118822 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 Aravind K N arav...@gmail.com changed: What|Removed |Added CC||arav...@gmail.com --- Comment #1 from Aravind K N arav...@gmail.com --- I would like to work on this bug. Would someone assign this to me? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added CC||01tonytho...@gmail.com --- Comment #2 from Tony Thomas 01tonytho...@gmail.com --- Prepare the patch http://www.mediawiki.org/wiki/Gerrit/Tutorial -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 Aaron Schulz aschulz4...@gmail.com changed: What|Removed |Added CC||aschulz4...@gmail.com Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54749] thumb.php should output docs if no file specified
https://bugzilla.wikimedia.org/show_bug.cgi?id=54749 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l