[Bug 55825] Overlapping with noinclude causes breakage (like noincludepoem/noinclude/poem)
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low Summary|Overlapping with|Overlapping with |noinclude causes breakage |noinclude causes breakage ||(like ||noincludepoem/noinclud ||e/poem) Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55825] Overlapping with noinclude causes breakage
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825
--- Comment #6 from billinghurst billinghu...@gmail.com ---
No different from if you were incorrectly using ref, pre, nowiki and
other hacks of html, where if you don't close tags before opening others it
breaks. Remember that they are not true html tags. Try and put some expanding
templates inside some tags and they fail miserably, which is why we have magic
words like {{#tag:...}} to make things function properly, the issue is as
stated above, we are not properly nesting open and closing of tags.
Poem is just a formatting, nothing more, it neither shows starts nor ends of
poems. You can correctly format poems by closing the poem tag inside
noinclude. Alterntiavely, if you want correctly formatted then you can format
without using poem and just use br /
The issue is also due to the ProofreadPage extension and how we stick pages
together, and have the header and footer components on the one page where it is
just a javascript presentation, rather than three separate components. It is
all less than perfect. C'est la vie.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55825] Overlapping with noinclude causes breakage
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825
--- Comment #7 from djr...@riseup.net ---
(In reply to comment #6)
No different from if you were incorrectly using ref, pre, nowiki and
other hacks of html, where if you don't close tags before opening others it
breaks. Remember that they are not true html tags. Try and put some
expanding
templates inside some tags and they fail miserably, which is why we have
magic
words like {{#tag:...}} to make things function properly, the issue is as
stated above, we are not properly nesting open and closing of tags.
Poem is just a formatting, nothing more, it neither shows starts nor ends of
poems. You can correctly format poems by closing the poem tag inside
noinclude. Alterntiavely, if you want correctly formatted then you can
format
without using poem and just use br /
The issue is also due to the ProofreadPage extension and how we stick pages
together, and have the header and footer components on the one page where it
is
just a javascript presentation, rather than three separate components. It is
all less than perfect. C'est la vie.
The testcase page I linked shows that this happens without ProofreadPage's
javascript effects. What you can and can't do by avoiding using poem is a
mixed bag. There's a few tests on the linked test page, feel free to mess
around with these.
While I would like to emphasize the apparent issues of poem breaking
noinclude, if it's as simple as fix issue by not using tag at all, then
please mark this bug as won't fix. (Sorry if I come off as rude, just trying
to be brief!)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55825] Overlapping with noinclude causes breakage
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825 --- Comment #8 from billinghurst billinghu...@gmail.com --- Not my call on how to rate this, I am not a hacker. I am more saying that this is an artefact of a local tag (WMF) that is not standards compliant, and it is just one of many that have a similar behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55825] Overlapping with noinclude causes breakage
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825 billinghurst billinghu...@gmail.com changed: What|Removed |Added CC||billinghu...@gmail.com --- Comment #4 from billinghurst billinghu...@gmail.com --- The solution is to simply close the poem tag before the noinclude, then reopen it another time. If the poem tag formatting is neutral, then it works well enough. Both tags are hacks. shrug -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55825] Overlapping with noinclude causes breakage
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825 --- Comment #5 from djr...@riseup.net --- (In reply to comment #3) noinclude (and includeonly and onlyinclude) a prefered over any other tag, because there are special for the parser. You can use poemnowiki/noinclude/nowiki/poem when you want noinclude show as poem. Right, the problem is that poem is causing noinclude to show when it isn't meant to, among other related issues. (In reply to comment #4) The solution is to simply close the poem tag before the noinclude, then reopen it another time. If the poem tag formatting is neutral, then it works well enough. Both tags are hacks. shrug That's a way to avoid the conflict, yes. The problem, if this is to be considered problematic, is that it's semantically incorrect. You end up with multiple sequential poems, marked in HTML as multiple independently identified and formatted divs and paragraphs, rather than one continuous poem/HTML div/paragraph. But beyond that, unless I am mistaken, it might perhaps be considered a bug that poem can break noinclude to begin with. Thanks, -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55825] Overlapping with noinclude causes breakage
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825 --- Comment #1 from Andre Klapper aklap...@wikimedia.org --- Is there a minimal testcase (e.g. wikipage) to reproduce the problem? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55825] Overlapping with noinclude causes breakage
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825 --- Comment #2 from djr...@riseup.net --- (In reply to comment #1) Is there a minimal testcase (e.g. wikipage) to reproduce the problem? Yes, I put one in the URL field of the bug: https://test.wikipedia.org/wiki/Multipage_poem_test Thanks, -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55825] Overlapping with noinclude causes breakage
https://bugzilla.wikimedia.org/show_bug.cgi?id=55825 db duplicate...@googlemail.com changed: What|Removed |Added CC||duplicate...@googlemail.com --- Comment #3 from db duplicate...@googlemail.com --- noinclude (and includeonly and onlyinclude) a prefered over any other tag, because there are special for the parser. You can use poemnowiki/noinclude/nowiki/poem when you want noinclude show as poem. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
