https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #20 from Željko Filipin zfili...@wikimedia.org ---
Thanks Dan, I have tested this and it works great! :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 160024 merged by jenkins-bot:
Stricter pending behavior for falsely passing steps
https://gerrit.wikimedia.org/r/160024
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
Dan Duvall dduv...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #16 from Željko Filipin zfili...@wikimedia.org ---
(In reply to Dan Duvall from comment #15)
I think I'd still rather just reimplement pending for our own Cucumber World
(see comment 9) over monkey patching Cucumber::Pending (#1)
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 160024 had a related patch set uploaded by Dduvall:
Stricter pending behavior for falsely passing steps
https://gerrit.wikimedia.org/r/160024
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #15 from Dan Duvall dduv...@wikimedia.org ---
I think I'd still rather just reimplement pending for our own Cucumber World
(see comment 9) over monkey patching Cucumber::Pending (#1) or adding another
dependency (#2).
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #14 from Željko Filipin zfili...@wikimedia.org ---
I see, that was what I misunderstood. Thanks. :)
Ok then, so we could do three things:
#1 patch Cucumber::Pending
#2 require RSpec::Core::Pending and use it
#3 report a bug for
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #12 from Željko Filipin zfili...@wikimedia.org ---
As far as I understand it, Cucumber does use rspec, that is why we explicitly
use rspec-expectations[2].
1:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #13 from Dan Duvall dduv...@wikimedia.org ---
Right, but rspec-expectations is separate from rspec-core which is what
implements `describe`, `it`, `pending`, etc.
--
You are receiving this mail because:
You are the assignee for
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #10 from Željko Filipin zfili...@wikimedia.org ---
I think just my Ruby-fu is failing me. See comments 6 and 7. RSpec::Pending
already does what I want, but looks like I am calling Cucumber::Pending here:
pending('bug #56081') do
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #11 from Dan Duvall dduv...@wikimedia.org ---
I'm not sure that cucumber even uses `rspec-core`. It might just use the
matchers. Either way, I think implementing our own helper is more inline with
the Cucumber Way—not that I think
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #9 from Dan Duvall dduv...@wikimedia.org ---
We could reimplement `#pending` in a world helper module and rescue/re-raise
the `Cucumber::Pending` exception as something else.
module MediawikiSelenium::Pending
class Failure
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
Željko Filipin zfili...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
Željko Filipin zfili...@wikimedia.org changed:
What|Removed |Added
Summary|Cucumber step should fail |Cucumber step
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
Željko Filipin zfili...@wikimedia.org changed:
What|Removed |Added
Summary|Mark a scenario as failed |Cucumber step
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #1 from Željko Filipin zfili...@wikimedia.org ---
The documentation says I am expecting the correct behavior:
https://github.com/rspec/rspec-core/blob/master/lib/rspec/core/pending.rb?source=cc#L50-L57
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #2 from Željko Filipin zfili...@wikimedia.org ---
Cucumber output if the step is not marked pending:
$ bundle exec cucumber features/font_selection.feature:23
Using the default profile...
F-
(::) failed steps (::)
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #4 from Željko Filipin zfili...@wikimedia.org ---
But formatter called pretty gives more information (... 'bug #56081
(Cucumber::Pending)' ...):
$ bundle exec cucumber -f pretty features/font_selection.feature:23
Using the
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #3 from Željko Filipin zfili...@wikimedia.org ---
If the step is marked as pending, the default Cucumber formatter (progress)
does not give a lot of information:
$ bundle exec cucumber features/font_selection.feature:23
Using the
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #5 from Željko Filipin zfili...@wikimedia.org ---
But if change the expectation to the example from rspec documentation (so the
expectation inside the pending block no longer fails:
pending('bug #56081') do
true.should
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #6 from Željko Filipin zfili...@wikimedia.org ---
I think the problem is that we are using Cucumber::Pending instead of
RSpec::Pending, and looks like Cucumber does not behave like RSpec.
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56243
--- Comment #7 from Željko Filipin zfili...@wikimedia.org ---
I am not sure how to call RSpec#pending from Cucumber, I have tried this:
RSpec::Core::Pending.pending('bug #56081')
but no luck:
uninitialized constant RSpec::Core (NameError)
23 matches
Mail list logo
