[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 161340 had a related patch set uploaded by Prtksxna: SpecialChangeEmail: Use vform and remove wrapper https://gerrit.wikimedia.org/r/161340 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 161339 had a related patch set uploaded by Prtksxna: SpecialChangeEmail: Remove cancel button https://gerrit.wikimedia.org/r/161339 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 161339 merged by jenkins-bot: SpecialChangeEmail: Remove cancel button https://gerrit.wikimedia.org/r/161339 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 161340 merged by jenkins-bot: SpecialChangeEmail: Use vform and remove wrapper https://gerrit.wikimedia.org/r/161340 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 121975 abandoned by Jdlrobson: ChangeEmail special page rewritten to use vforms. Reason: Prateek just resolved the bug. Thanks for the help getting us there Ganeshaditya1! :) https://gerrit.wikimedia.org/r/121975 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 Jon jrob...@wikimedia.org changed: What|Removed |Added Blocks||70913 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #13 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org --- When I hit cancel I get the error Enter a valid email address which seems to imply its doing form validation, on cancel, which is very odd. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=69723 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=70676 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #14 from Matthew Flaschen mflasc...@wikimedia.org --- (In reply to Jared Zimmerman (WMF) from comment #13) When I hit cancel I get the error Enter a valid email address which seems to imply its doing form validation, on cancel, which is very odd. Confirmed. This is present in production too. I think the reason I couldn't reproduce it before is that it only happens after you've blurred the email field. You get one chance to type a valid email, then on blur it starts warning you if it's not valid. As you say, it validates it on cancel too, which is a bug (filed as bug 70676). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #10 from Jon jrob...@wikimedia.org --- ... or we could just remove the cancel button. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #11 from Bartosz Dziewoński matma@gmail.com --- I like the It causes problems? Remove it! approach, we should do this more often. I wonder which extensions cause the most trouble, maybe we should remove them? : -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #12 from Matthew Flaschen mflasc...@wikimedia.org --- Even if we do remove it, I would still like to know what the error is. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #9 from Matthew Flaschen mflasc...@wikimedia.org --- I agree a cancel button is not really useful here, but in the meantime we should not be showing errors for it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #8 from Matthew Flaschen mflasc...@wikimedia.org --- (In reply to Jared Zimmerman (WMF) from comment #7) Cancel just returns an error for me now anyway. On what wiki? It works for me on production English Wikipedia as well as Beta Labs English Wikipedia. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #4 from Jon jrob...@wikimedia.org --- *** Bug 70426 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #5 from Jon jrob...@wikimedia.org --- Should we also remove the cancel button as part of this? It seems strange to have a cancel button in this context. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added CC||legoktm.wikipe...@gmail.com --- Comment #6 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- Change-Id: I629cee4264fad6cde98495c0e8daffe5ea245b48 converted Special:ChangeEmail to use HTMLForm, now it just needs updating to use vform styling which should be much easier now. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 --- Comment #7 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org --- Cancel just returns an error for me now anyway. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56363] VForm: [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 Jon jrob...@wikimedia.org changed: What|Removed |Added Summary|[[Special:ChangeEmail]] |VForm: |form should be rewritten to |[[Special:ChangeEmail]] |use HTMLForm with vform |form should be rewritten to |styling and prettier error |use HTMLForm with vform |messages|styling and prettier error ||messages --- Comment #3 from Jon jrob...@wikimedia.org --- So to summarise this bug: * Add mw-ui-vform class to form with id mw-changeemail-form * Render errors and success messages inside the form with the errorbox class as outlined in MediaWiki UI / VForm section. Is the patch still being worked on? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
