[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Blocks||65243 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW CC||legoktm.wikipe...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118449 abandoned by Matthias Mullie: Add selectors for Parsoid-output external links Reason: Looks like Parsoid is working on this https://gerrit.wikimedia.org/r/118449 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118447 abandoned by Matthias Mullie: Add selectors for Parsoid-output external links Reason: Looks like Parsoid is working on this https://gerrit.wikimedia.org/r/118447 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118450 abandoned by Matthias Mullie: Add selector for Parsoid-output external links Reason: Looks like Parsoid is working on this https://gerrit.wikimedia.org/r/118450 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118448 abandoned by Matthias Mullie: Add selector for Parsoid-output external links Reason: Looks like Parsoid is working on this https://gerrit.wikimedia.org/r/118448 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118451 abandoned by Matthias Mullie: Add selector for Parsoid-output external links Reason: Looks like Parsoid is working on this https://gerrit.wikimedia.org/r/118451 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118452 abandoned by Matthias Mullie: Add selectors for Parsoid-output external links Reason: Looks like Parsoid is working on this https://gerrit.wikimedia.org/r/118452 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #12 from Matthias Mullie mmul...@wikimedia.org --- I noticed trying to generalize CSS / JS integration for Flow, VE etc under Parsoid in the notes of the last scrum of scrums; I assume it's related to this bug. https://www.mediawiki.org/wiki/Scrum_of_scrums/2014-03-19 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118447 had a related patch set uploaded by Matthias Mullie: Add selectors for Parsoid-output external links https://gerrit.wikimedia.org/r/118447 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118448 had a related patch set uploaded by Matthias Mullie: Add selector for Parsoid-output external links https://gerrit.wikimedia.org/r/118448 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118449 had a related patch set uploaded by Matthias Mullie: Add selectors for Parsoid-output external links https://gerrit.wikimedia.org/r/118449 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118450 had a related patch set uploaded by Matthias Mullie: Add selector for Parsoid-output external links https://gerrit.wikimedia.org/r/118450 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118451 had a related patch set uploaded by Matthias Mullie: Add selector for Parsoid-output external links https://gerrit.wikimedia.org/r/118451 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118452 had a related patch set uploaded by Matthias Mullie: Add selectors for Parsoid-output external links https://gerrit.wikimedia.org/r/118452 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 Matthias Mullie mmul...@wikimedia.org changed: What|Removed |Added CC||mmul...@wikimedia.org --- Comment #10 from Matthias Mullie mmul...@wikimedia.org --- There's a couple of ways we could go about this: * Parsoid could add class=external to external links * Skins' CSS could target [rel=mw:ExtLink] too, like it currently only targets .external * Flow could hack around this, finding [rel=mw:ExtLink] links and adding class=external I would prefer not to do #3. I've uploaded a couple of patches that should do #2 in all skins extensions that currently only target .external. Not sure if that's going to be an approach everyone will agree with. If it is, I'll do the same for rel=nofollow -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 Matthias Mullie mmul...@wikimedia.org changed: What|Removed |Added Depends on||51245, 52617 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 Jon jrob...@wikimedia.org changed: What|Removed |Added CC||jrob...@wikimedia.org --- Comment #11 from Jon jrob...@wikimedia.org --- Shouldn't Parsoid simply use the external link class so we can turn that into a defacto standard? Is there any reason it can't? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 Oliver Keyes oke...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 --- Comment #3 from Gabriel Wicke gwi...@wikimedia.org --- The class does not seem to be needed in Parsoid output as the typeof attribute can be used instead. Creating updated styles is bug 51245. rel=nofollow is bug 52617. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756 Quiddity pandiculat...@gmail.com changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=57451 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56756] Flow: Parsoid doesn't give external links class=external text or rel=nofollow
https://bugzilla.wikimedia.org/show_bug.cgi?id=56756
sp...@wikimedia.org changed:
What|Removed |Added
CC||gwi...@wikimedia.org
Summary|Flow: external link icons |Flow: Parsoid doesn't give
|are not appearing |external links
||class=external text or
||rel=nofollow
--- Comment #2 from sp...@wikimedia.org ---
Parsoid knows it's an external link but doesn't add the class external text,
or rel=nofollow that a link in article HTML has.
spage@ee-flow:~$ curl -d 'wt=[http://example.com external]' -d 'body=1'
localhost:8000/localhost/Main_Page
...
a rel=mw:ExtLink href=http://example.com;
data-parsoid='{targetOff:20,contentOffsets:[20,28],dsr:[0,29,20,1]}'external/a
compared with wikitext HTML:
a href=http://example.com; class=external text rel=nofollowexternal/a
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
