[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

--- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 96970 merged by MarkAHershberger:
Fix login with temporary password with $wgSecureLogin = true

https://gerrit.wikimedia.org/r/96970

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

--- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 96994 merged by MarkAHershberger:
Fix login with temporary password with $wgSecureLogin = true

https://gerrit.wikimedia.org/r/96994

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

Tyler Romeo tylerro...@gmail.com changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

T. Gries m...@tgries.de changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #13 from T. Gries m...@tgries.de ---
In www.mediawiki,org : Not solved


After changing the password, see http://i.imgur.com/7ADHPHH.png

URL:

https://www.mediawiki.org/w/index.php?title=Special:ChangePasswordreturnto=returntoquery=fromhttp=1

Problem is not solved, in my view.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

Tyler Romeo tylerro...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Tyler Romeo tylerro...@gmail.com ---
That's because the fix has not been deployed yet. However, the actual bug in
question has been resolved in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

--- Comment #15 from T. Gries m...@tgries.de ---
Tyler: okay. I understand this from a discussion in the chat some minutes ago.
ty

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

--- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 96970 had a related patch set uploaded by IAlex:
Fix login with temporary password with $wgSecureLogin = true

https://gerrit.wikimedia.org/r/96970

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

Tyler Romeo tylerro...@gmail.com changed:

   What|Removed |Added

   Keywords||code-update-regression
 CC||tylerro...@gmail.com

--- Comment #9 from Tyler Romeo tylerro...@gmail.com ---
For the record, the cause of this bug is from Ia0a61e98fbff7 (
https://gerrit.wikimedia.org/r/93425), which introduced WebRequest::getProtocol
as an instance method rather than the previous practice of always using
WebRequest::detectProtocol, which is static.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

--- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 96994 had a related patch set uploaded by MarkAHershberger:
Fix login with temporary password with $wgSecureLogin = true

https://gerrit.wikimedia.org/r/96994

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

--- Comment #7 from T. Gries m...@tgries.de ---
screenshot of the page after successfully having entered the temp.password and
2x the new password:

+ http://i.imgur.com/IDNp8W4.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

T. Gries m...@tgries.de changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=57065

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

--- Comment #4 from T. Gries m...@tgries.de ---
 Needed to log in once again. Meh.

just to say it very kindly again in case it has been overlooked:
 __perhaps_(!)_ the fix of 
 https://bugzilla.wikimedia.org/show_bug.cgi?id=57098 solves this, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

--- Comment #5 from Chris Steipp cste...@wikimedia.org ---
Is this still happening? I'm not able to reproduce it. Just to confirm,

* I enter my username and temp password, click login
* I get the change password form. I'm not logged in. Old password is
pre-filled.
* I enter in a new password (twice), and click submit.
* I'm taken back to Main_Page, and I'm logged in.

Am I missing a step?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57289] Invalid Change Password (returnto) page shown after successful temporary password login password change

2013-11-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

T. Gries m...@tgries.de changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #6 from T. Gries m...@tgries.de ---
(In reply to comment #5)
 Is this still happening? I'm not able to reproduce it. Just to confirm,
 
 * I enter my username and temp password, click login
 * I get the change password form. I'm not logged in. Old password is
 pre-filled.
 * I enter in a new password (twice), and click submit.
 * I'm taken back to Main_Page, and I'm logged in.
 
 Am I missing a step?

Yes, certainly.
I still can reproduce my findings as in the first comment, and as confirmed by
André in https://bugzilla.wikimedia.org/show_bug.cgi?id=57289#c3


Please reproduce step-by-step:


Scenario:

+ en.wikipedia.org as of 2013-11-22
+ go to Reset Password page and trigger the I-forgot-my-passwort
e-mail-password mail
+ come back to the login page
+ enter the temporary password
+ you are now correctly asked to change your password (=mandatory password
change after login with temporary password)
+ after a successful password change you will see

Change Password (=page title)
You must be logged in to access this page directly.

URL is: 
https://en.wikipedia.org/w/index.php?title=Special:ChangePasswordreturnto=returntoquery=fromhttp=1;

This is *strictly* reproducible. Raising severity to major because it relates
to a password issue, which could point to critical bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l