https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
Željko Filipin zfili...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 100209 had a related patch set uploaded by Zfilipin:
Use snake case
https://gerrit.wikimedia.org/r/100209
--
You are receiving this mail because:
You are the
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 101054 abandoned by Zfilipin:
Use snake_case in Aliases
Reason:
Changes made to files in /selenium folder are out of scope for this Google
Code-in task. I have
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 101054 had a related patch set uploaded by Aaron1011:
Use snake_case in Aliases
https://gerrit.wikimedia.org/r/101054
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
Željko Filipin zfili...@wikimedia.org changed:
What|Removed |Added
Keywords||easy
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #3 from Željko Filipin zfili...@wikimedia.org ---
Leo Xiong, Google Code-in student has claimed the task:
https://www.google-melange.com/gci/task/view/google/gci2013/5259991820795904
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #4 from Željko Filipin zfili...@wikimedia.org ---
After you make the change, check syntax of all Ruby files in a repository with
this (if you are on Mac/Linux):
find . -name *.rb -exec ruby -wc {} \;
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #5 from Željko Filipin zfili...@wikimedia.org ---
CamelCase should still be used for classes and modules, do not change those.
For example, this should not be changed (from alias_module.rb[1]):
module AliasPage
include PageObject
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
Željko Filipin zfili...@wikimedia.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
Željko Filipin zfili...@wikimedia.org changed:
What|Removed |Added
URL|
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #1 from Željko Filipin zfili...@wikimedia.org ---
This is similar to bug #57597.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #2 from Željko Filipin zfili...@wikimedia.org ---
What needs to be done?
#1 clone repositories listed here:
https://github.com/wikimedia/mediawiki-selenium#links (use Gerrit link, not
GitHub link)
#2 inspect all Ruby files (.rb)
13 matches
Mail list logo