https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #12 from Mark A. Hershberger ---
Kevin,
Thanks for adding me to this bug. I didn't know about it before.
I was going to talk to Antoine about this but was focused on trying to do the
release. This is incredibly annoying.
--
Yo
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
Antoine "hashar" Musso changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|F
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
Kevin Israel (PleaseStand) changed:
What|Removed |Added
CC||m...@everybody.org,
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
Antoine "hashar" Musso changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|-
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
Antoine "hashar" Musso changed:
What|Removed |Added
Blocks||47063
--
You are receiving t
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #8 from Gerrit Notification Bot ---
Change 102621 merged by Aaron Schulz:
Added a MemoryFileBackend class and made MockFileBackend subclass it
https://gerrit.wikimedia.org/r/102621
--
You are receiving this mail because:
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #7 from Gerrit Notification Bot ---
Change 102621 had a related patch set uploaded by Aaron Schulz:
Added a MemoryFileBackend class and made MockFileBackend subclass it
https://gerrit.wikimedia.org/r/102621
--
You are receiving t
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #6 from Marcin Cieślak ---
I have a simpler/better idea (I think). What about teaching wfTempDir() to
create a per-wiki instance directory under /tmp
and adding a new function wfTempFile() á la UNIX mkstemp() that would
allow
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #5 from Antoine "hashar" Musso ---
Maybe the MockFSFile can be slightly extended to let us write some content in,
except the file payload would be an object property in memory instead of
written to disk. The getSha36() would then s
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #4 from Marcin Cieślak ---
But that's not mocking that we need in this test (pretending that the file is
created) - we need to create an actual file (ok, just a stream of bytes). We do
care about the contents and not faking the mere
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #3 from Antoine "hashar" Musso ---
I wrote MockFileBackend and MockFSFile which let you create fake files which
are purely virtual.
In phpunit/includes/parser/NewParserTest.php we explicitly create a local file
i.e.:
$image = wfL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #2 from Marcin Cieślak ---
(In reply to comment #1)
> Yup we should mock the file system access :-(
OMG, no!
just use /tmp/Foobar${uniquetestinstanceidentifier}.svg
Test instance ID might come from Jenkins (maybe?) or just random
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
Andre Klapper changed:
What|Removed |Added
Priority|Unprioritized |Low
--
You are receiving this mail be
https://bugzilla.wikimedia.org/show_bug.cgi?id=58094
--- Comment #1 from Antoine "hashar" Musso ---
Yup we should mock the file system access :-(
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
15 matches
Mail list logo
