[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 174585 had a related patch set uploaded by Kaldari: Adding Wikipedia wordmark for mobile and switching to it https://gerrit.wikimedia.org/r/174585 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 174585 merged by jenkins-bot: Adding Wikipedia wordmark for mobile and switching to it https://gerrit.wikimedia.org/r/174585 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 Ryan Kaldari rkald...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Ryan Kaldari rkald...@wikimedia.org --- Fixed on test.wiki. Should go out to en.wiki soon. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 174218 had a related patch set uploaded by Bmansurov: Add footer logo dimensions https://gerrit.wikimedia.org/r/174218 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 Jon jrob...@wikimedia.org changed: What|Removed |Added Keywords||easy Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from Jon jrob...@wikimedia.org --- So it sounds like we just need to use getimagesize and add the image width and height to SkinMinerva::getSitename function Should be easy to do so let's just do it. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 --- Comment #7 from Bingle bingle-ad...@wikimedia.org --- Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/wNb5TP4s -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 --- Comment #4 from Juliusz Gonera jgon...@wikimedia.org --- Ori, is this really a performance issue? I can't imagine one image slowing down rendering significantly. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 Ori Livneh o...@wikimedia.org changed: What|Removed |Added CC||o...@wikimedia.org --- Comment #5 from Ori Livneh o...@wikimedia.org --- (In reply to Juliusz Gonera from comment #4) Ori, is this really a performance issue? I can't imagine one image slowing down rendering significantly. Those are two different questions. It's worth the effort to fix, if that's what you're asking. https://developers.google.com/speed/docs/best-practices/rendering#SpecifyImageDimensions http://www.feedthebot.com/pagespeed/image-dimensions.html -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Jon jrob...@wikimedia.org --- Waiting on a response from Ori -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886 --- Comment #1 from Bingle bingle-ad...@wikimedia.org --- Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1574 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58886] Image tag for enwiki project logo should specify dimensions and use a stable URL
https://bugzilla.wikimedia.org/show_bug.cgi?id=58886
--- Comment #2 from Jon jrob...@wikimedia.org ---
I think it also meant to be slightly bigger to look nice on retina displays.
I guess what you are saying is rather than specifying the height in ems we
specify it in pixels?
In terms of volatile URL, this is all done in config...
I'm guessing the offending line is:
$wmgMFCustomLogos['copyright'] = str_replace( '{wgExtensionAssetsPath}',
$wgExtensionAssetsPath, $wmgMFCustomLogos['copyright'] );
Would it be better to use an absolute URL here? Considering this is on every
page we should be careful where this image is hosted...
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
