[Bug 58926] Several issues in round-trip test server
https://bugzilla.wikimedia.org/show_bug.cgi?id=58926 Marc Ordinas i Llopis marc...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58926] Several issues in round-trip test server
https://bugzilla.wikimedia.org/show_bug.cgi?id=58926 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58926] Several issues in round-trip test server
https://bugzilla.wikimedia.org/show_bug.cgi?id=58926 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 106672 had a related patch set uploaded by Marcoil: Bug 58926: Keep track of known commits in rt server https://gerrit.wikimedia.org/r/106672 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58926] Several issues in round-trip test server
https://bugzilla.wikimedia.org/show_bug.cgi?id=58926 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 106672 merged by jenkins-bot: Bug 58926: Keep track of known commits in rt server https://gerrit.wikimedia.org/r/106672 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58926] Several issues in round-trip test server
https://bugzilla.wikimedia.org/show_bug.cgi?id=58926 Marc Ordinas i Llopis marc...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58926] Several issues in round-trip test server
https://bugzilla.wikimedia.org/show_bug.cgi?id=58926 --- Comment #5 from Marc Ordinas i Llopis marc...@wikimedia.org --- (In reply to comment #0) 1) A client working on an older revision causes the rt test server to hang for all other clients. We should reject requests for anything but the last revision. It may be due to reloading a title batch. If a client request comes from a different commit than the last one, the current batch is discarded, as the set of electable pages could be different. Unfortunately, commit hashes are not time-ordered, and we presupposed that clients would move forward. We could reject incoming requests if they are not from either: - The latest recorded commit hash, or - A completely new commit hash that we didn't know about. That would introduce a delay, though… -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58926] Several issues in round-trip test server
https://bugzilla.wikimedia.org/show_bug.cgi?id=58926 --- Comment #6 from Gabriel Wicke gwi...@wikimedia.org --- (In reply to comment #5) Unfortunately, commit hashes are not time-ordered, and we presupposed that clients would move forward. Our commits table has a timestamp for each commit (IIRC based on the actual commit timestamp even). This makes it possible to determine what the last known commit is. We could reject incoming requests if they are not from either: - The latest recorded commit hash, or - A completely new commit hash that we didn't know about. That would introduce a delay, though… We can just store the hashes we know about and the latest hash in variables. Checking those is cheap and should not add any appreciable delay. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58926] Several issues in round-trip test server
https://bugzilla.wikimedia.org/show_bug.cgi?id=58926 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW Summary|Several issues in rt test |Several issues in |server |round-trip test server --- Comment #4 from Gabriel Wicke gwi...@wikimedia.org --- (In reply to comment #3) note for bug wrangler: doesn't sound like _that_ RT. Changed the summary so that you folks not checking the product are not confused ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l