https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Florian changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #20 from Gerrit Notification Bot ---
Change 135563 merged by Aaron Schulz:
Changed $article to be instance of WikiPage
https://gerrit.wikimedia.org/r/135563
--
You are receiving this mail because:
You are the assignee for the bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #19 from glen...@gmail.com ---
It seems to have worked fine. +1
Thanks for your help!
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #18 from glen...@gmail.com ---
Nice, I tested it as well locally, and it seemed to work (although I only had
one page).
I will try it in production now, after I confirm that we have a backup.
--
You are receiving this mail because
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #17 from Gerrit Notification Bot ---
Change 135563 had a related patch set uploaded by Florianschmidtwelzow:
Changed $article to be instance of WikiPage
https://gerrit.wikimedia.org/r/135563
--
You are receiving this mail because
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Gerrit Notification Bot changed:
What|Removed |Added
Status|REOPENED|PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #16 from Florian ---
I have tested it now, seems to be the right change. I will commit it soon and
then we see, what the project owners say to it, if i'm right, that we can
simply change the class :)
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #15 from Florian ---
If i were you, i would test this on a testwiki ;) But normally it's safe :) If
i have time, i will install flaggedrev and look :)
--
You are receiving this mail because:
You are the assignee for the bug.
You a
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #14 from glen...@gmail.com ---
Is it fairly safe to do so?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mai
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #13 from Florian ---
I haven't installed FlaggedRevs, so can maybe someone change simple Article to
WikiPage?
https://github.com/wikimedia/mediawiki-extensions-FlaggedRevs/blob/23a84dc37dc0d13027209d7f68ad9cbba4bdbe6a/maintenance/re
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #12 from glen...@gmail.com ---
(In reply to Florian from comment #11)
> Because var article is an instance of class Artcile:
> $article = new Article( $title );
Sorry, I wasn't clear. I know that, I just don't know why this class is
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Florian changed:
What|Removed |Added
CC||florian.schmidt.welzow@t-on
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #10 from glen...@gmail.com ---
If I do this:
if ( $page instanceof FlaggableWikiPage ) {
$article = $page;
} elseif ( $page instanceof WikiPage ) {
$article = FlaggableWikiPage::getTitleInstan
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
glen...@gmail.com changed:
What|Removed |Added
CC||glen...@gmail.com
--- Comment #9 fr
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Andre Klapper changed:
What|Removed |Added
Severity|critical|major
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Andre Klapper changed:
What|Removed |Added
Priority|Unprioritized |Normal
Status|RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #7 from Piotr ---
Hi Andre,
This is the result from relative paths:
yoga:/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance
# php reviewAllPages.php --conf ../../../LocalSettings.php --username admin
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
Andre Klapper changed:
What|Removed |Added
Summary|reviewAllPages.php doesn't |reviewAllPages.php doesn't
18 matches
Mail list logo