[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 135563 merged by Aaron Schulz: Changed $article to be instance of WikiPage https://gerrit.wikimedia.org/r/135563 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
glen...@gmail.com changed:
What|Removed |Added
CC||glen...@gmail.com
--- Comment #9 from glen...@gmail.com ---
I have the same issue with MW 1.22.6 on PHP 5.5.12.
[60eb825b] [no req] Exception from line 615 of
/var/www/clients/client1/web2/web/mediawiki/extensions/FlaggedRevs/backend/FlaggedRevs.class.php:
First argument must be a Title or WikiPage.
Backtrace:
#0
/var/www/clients/client1/web2/web/mediawiki/extensions/FlaggedRevs/backend/FlaggedRevs.class.php(1028):
FlaggedRevs::stableVersionUpdates(Article)
#1
/var/www/clients/client1/web2/web/mediawiki/extensions/FlaggedRevs/maintenance/reviewAllPages.php(76):
FlaggedRevs::autoReviewEdit(Article, User, Revision, array, boolean)
#2
/var/www/clients/client1/web2/web/mediawiki/extensions/FlaggedRevs/maintenance/reviewAllPages.php(26):
ReviewAllPages-autoreview_current(User)
#3
/var/www/clients/client1/web2/web/mediawiki/maintenance/doMaintenance.php(113):
ReviewAllPages-execute()
#4
/var/www/clients/client1/web2/web/mediawiki/extensions/FlaggedRevs/maintenance/reviewAllPages.php(99):
require_once(string)
#5 {main}
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #10 from glen...@gmail.com ---
If I do this:
if ( $page instanceof FlaggableWikiPage ) {
$article = $page;
} elseif ( $page instanceof WikiPage ) {
$article = FlaggableWikiPage::getTitleInstance( $page-getTitle()
);
} elseif ( $page instanceof Title ) {
$article = FlaggableWikiPage::getTitleInstance( $page );
} else {
var_dump(get_class($page)); // *** HERE ***
throw new MWException( First argument must be a Title or
WikiPage. );
}
It prints Article -- I have no idea what that means, but I'm sure you do. :-)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added CC||florian.schmidt.welzow@t-on ||line.de --- Comment #11 from Florian florian.schmidt.wel...@t-online.de --- Because var article is an instance of class Artcile: $article = new Article( $title ); -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #12 from glen...@gmail.com --- (In reply to Florian from comment #11) Because var article is an instance of class Artcile: $article = new Article( $title ); Sorry, I wasn't clear. I know that, I just don't know why this class is not handled. Is it new? Is it old? Should this ever happen? What's the difference between a FlaggableWikiPage / WikiPage / Article, etc. Let me know if you need any more information. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #13 from Florian florian.schmidt.wel...@t-online.de --- I haven't installed FlaggedRevs, so can maybe someone change simple Article to WikiPage? https://github.com/wikimedia/mediawiki-extensions-FlaggedRevs/blob/23a84dc37dc0d13027209d7f68ad9cbba4bdbe6a/maintenance/reviewAllPages.php#L74 In this line, if i looked right, the instance is only used there, so we can use WikiPage instead of Article. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #14 from glen...@gmail.com --- Is it fairly safe to do so? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #15 from Florian florian.schmidt.wel...@t-online.de --- If i were you, i would test this on a testwiki ;) But normally it's safe :) If i have time, i will install flaggedrev and look :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #16 from Florian florian.schmidt.wel...@t-online.de --- I have tested it now, seems to be the right change. I will commit it soon and then we see, what the project owners say to it, if i'm right, that we can simply change the class :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 135563 had a related patch set uploaded by Florianschmidtwelzow: Changed $article to be instance of WikiPage https://gerrit.wikimedia.org/r/135563 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #18 from glen...@gmail.com --- Nice, I tested it as well locally, and it seemed to work (although I only had one page). I will try it in production now, after I confirm that we have a backup. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 --- Comment #19 from glen...@gmail.com --- It seems to have worked fine. +1 Thanks for your help! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal Status|RESOLVED|REOPENED Resolution|INVALID |--- Ever confirmed|0 |1 Severity|blocker |critical --- Comment #8 from Andre Klapper aklap...@wikimedia.org --- No reply either in https://www.mediawiki.org/wiki/Extension_talk:FlaggedRevs#ReviewAllPages.php_reports_errors_37351 :( -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Severity|critical|major -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012
--- Comment #7 from Piotr piotr.kry...@wp.pl ---
Hi Andre,
This is the result from relative paths:
yoga:/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance
# php reviewAllPages.php --conf ../../../LocalSettings.php --username admin
Auto-reviewing all current page versions...
Reviewer username: Admin
...doing page_id from 1 to 100
First argument must be a Title or WikiPage.
Backtrace:
#0
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/backend/FlaggedRevs.class.php(1022):
FlaggedRevs::stableVersionUpdates(Object(Article))
#1
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(76):
FlaggedRevs::autoReviewEdit(Object(Article), Object(User), Object(Revision),
Array, true)
#2
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(26):
ReviewAllPages-autoreview_current(Object(User))
#3
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/maintenance/doMaintenance.php(110):
ReviewAllPages-execute()
#4
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(99):
require_once('/srv/www/htdocs...')
#5 {main}
This is the result from absolute paths:
yoga:/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance
# php
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php
--conf /srv/www/htdocs/mediawiki-1.21.1-II-instancja/LocalSettings.php
--username admin
Auto-reviewing all current page versions...
Reviewer username: Admin
...doing page_id from 1 to 100
First argument must be a Title or WikiPage.
Backtrace:
#0
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/backend/FlaggedRevs.class.php(1022):
FlaggedRevs::stableVersionUpdates(Object(Article))
#1
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(76):
FlaggedRevs::autoReviewEdit(Object(Article), Object(User), Object(Revision),
Array, true)
#2
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(26):
ReviewAllPages-autoreview_current(Object(User))
#3
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/maintenance/doMaintenance.php(110):
ReviewAllPages-execute()
#4
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(99):
require_once('/srv/www/htdocs...')
#5 {main}
and the third attempt results
yoga:/srv/www/htdocs/mediawiki-1.21.1-II-instancja # php
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php
--conf /srv/www/htdocs/mediawiki-1.21.1-II-instancja/LocalSettings.php
--username admin
Auto-reviewing all current page versions...
Reviewer username: Admin
...doing page_id from 1 to 100
First argument must be a Title or WikiPage.
Backtrace:
#0
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/backend/FlaggedRevs.class.php(1022):
FlaggedRevs::stableVersionUpdates(Object(Article))
#1
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(76):
FlaggedRevs::autoReviewEdit(Object(Article), Object(User), Object(Revision),
Array, true)
#2
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(26):
ReviewAllPages-autoreview_current(Object(User))
#3
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/maintenance/doMaintenance.php(110):
ReviewAllPages-execute()
#4
/srv/www/htdocs/mediawiki-1.21.1-II-instancja/extensions/FlaggedRevs/maintenance/reviewAllPages.php(99):
require_once('/srv/www/htdocs...')
#5 {main}
Regards
Peter
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59012] reviewAllPages.php doesn't work triggers First argument must be a Title or WikiPage
https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Summary|reviewAllPages.php doesn't |reviewAllPages.php doesn't |work|work triggers First ||argument must be a Title or ||WikiPage --- Comment #6 from Andre Klapper aklap...@wikimedia.org --- Piotr: Please paste the output you get nowadays. Does using an absolute instead of a relative path as parameter help? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
