[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 13 had a related patch set uploaded by JGonera: Add Status outparam for AbortNewAccount hook to fix API error handling https://gerrit.wikimedia.org/r/13 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 18 had a related patch set uploaded by MaxSem: Update ConfirmEdit to return Status object on AbortNewAccount hook https://gerrit.wikimedia.org/r/18 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 18 merged by jenkins-bot: Update ConfirmEdit to return Status object on AbortNewAccount hook https://gerrit.wikimedia.org/r/18 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 13 merged by MaxSem: Add Status outparam for AbortNewAccount hook to fix API error handling https://gerrit.wikimedia.org/r/13 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108088 merged by jenkins-bot: Add Status outparam for AbortNewAccount hook to fix API error handling https://gerrit.wikimedia.org/r/108088 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 Brion Vibber br...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |br...@wikimedia.org |org | --- Comment #1 from Brion Vibber br...@wikimedia.org --- Taking this as we want this to work smoothly for mobile apps. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #2 from Brion Vibber br...@wikimedia.org --- I think the thing to do here is to allow sending back a *useful* Status object from the hook in place of just a string, which should be able to return a sane error. Lemme try... -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #3 from Tyler Romeo tylerro...@gmail.com --- The issue here is that the Status class is too intertwined with the Message class, and this was even before RawMessage was introduced. When you made a Status object, it was assumed any error keys were backed by messages. The solution should be that the concerns need to be separated. The Status class should not have anything to do with the Message class. However, that may be a bit difficult to achieve, so at the very least there needs to be a separation between error codes and message keys. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108088 had a related patch set uploaded by Brion VIBBER: Add Status outparam for AbortNewAccount hook to fix API error handling https://gerrit.wikimedia.org/r/108088 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108089 had a related patch set uploaded by Brion VIBBER: Update ConfirmEdit to return Status object on AbortNewAccount hook https://gerrit.wikimedia.org/r/108089 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #6 from Brion Vibber br...@wikimedia.org --- (In reply to comment #3) The issue here is that the Status class is too intertwined with the Message class, and this was even before RawMessage was introduced. When you made a Status object, it was assumed any error keys were backed by messages. The solution should be that the concerns need to be separated. The Status class should not have anything to do with the Message class. However, that may be a bit difficult to achieve, so at the very least there needs to be a separation between error codes and message keys. I'd rather not redo the entire interface of SpecialUserlogin and ApiCreateAccount just to get this going. Any strong objections to using this existing approach as a basic fix? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #7 from Tyler Romeo tylerro...@gmail.com --- (In reply to comment #6) Any strong objections to using this existing approach as a basic fix? Nope (as indicated by my +1). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #8 from Brion Vibber br...@wikimedia.org --- Yay! :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108089 merged by jenkins-bot: Update ConfirmEdit to return Status object on AbortNewAccount hook https://gerrit.wikimedia.org/r/108089 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60008] Special:UserLogin calls Status::newFatal incorrectly on account creation, generates odd API error codes
https://bugzilla.wikimedia.org/show_bug.cgi?id=60008 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
