[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 christ...@quelltextlich.at changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #16 from christ...@quelltextlich.at --- Fix has been deployed on 2014-07-08. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #15 from Gerrit Notification Bot --- Change 125181 merged by Chad: Set uploader to current user in "patchset-created" event upon cherry-picking https://gerrit.wikimedia.org/r/125181 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #14 from christ...@quelltextlich.at --- I've been told that we probably will not deploy this fix right away, but wait for gerrit 2.8.4 (which is just around the corner, and will include our fix). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #13 from christ...@quelltextlich.at --- (In reply to Antoine "hashar" Musso from comment #12) > I am wondering whether the other events are > suffering the same issue (i.e. abandoned patchset). I think we should be fine. For the patchset-created event, I know three ways to trigger it through the UI: * Rebasing a change (fixed) * Cherry-picking a change (fixed) * Editing commit message (worked already) (If you know further ways, please let me know) The draft-published event also has an uploader field. And it is not set to the current user when publishing a draft. But that is arguably ok, as the one who publishes a patch set is not necessarily the uploader of the patch set. Documentation is a bit scarce on that end, so it's hard to read off intentions from the gerrit devs. But as it's ok for draft-published, I did not change it there. All other events come without an uploader field, if grep did not fool me. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #12 from Antoine "hashar" Musso --- Thanks Chris that was quick. I am wondering whether the other events are suffering the same issue (i.e. abandoned patchset). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 Gerrit Notification Bot changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #11 from Gerrit Notification Bot --- Change 125181 had a related patch set uploaded by QChris: Set uploader to current user in "patchset-created" event upon cherry-picking https://gerrit.wikimedia.org/r/125181 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 Bartosz Dziewoński changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #10 from Bartosz Dziewoński --- This is still a problem when one uses the "Cherry Pick" button to cherry-pick a commit to the same branch (to remove dependencies): [21:14] (PS5) Prtksxna: Use tooltip role for Popups [extensions/Popups] - https://gerrit.wikimedia.org/r/120344 (I submitted that patchset using the method above, not Prtksxna.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #9 from Antoine "hashar" Musso --- works in Zuul as well. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 Bartosz Dziewoński changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #8 from Bartosz Dziewoński --- Yes. (Or at least grrrit-wm does.) Thank you! -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #6 from Gerrit Notification Bot --- Change 115316 merged by QChris: Set uploader to current user in "patchset-created" event upon rebasing https://gerrit.wikimedia.org/r/115316 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #7 from christ...@quelltextlich.at --- It seems new gerrit has been deployed on 2014-03-10 23:30. Does Zuul get the correct JSON objects now? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 Antoine "hashar" Musso changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED See Also||http://code.google.com/p/ge ||rrit/issues/detail?id=2493 Assignee|wikibugs-l@lists.wikimedia. |christ...@quelltextlich.at |org | --- Comment #5 from Antoine "hashar" Musso --- Upstream bug http://code.google.com/p/gerrit/issues/detail?id=2493 has been fixed by Christian (thus assigning bug to him since he did all the job). Upstream commit is https://gerrit-review.googlesource.com/#/c/54850/ Should be included in Gerrit 2.8.2. Backport of change in our Gerrit copy is proposed at https://gerrit.wikimedia.org/r/115316 I guess whenever it get deployed the issue will be solved :-] -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #4 from Gerrit Notification Bot --- Change 115316 had a related patch set uploaded by QChris: Set uploader to current user in "patchset-created" event upon rebasing https://gerrit.wikimedia.org/r/115316 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #3 from christ...@quelltextlich.at --- Since I'd forget otherwise: fd23ab518fbd5a3a8c02badd8583ade36cb30edb Refactor Rebase to use PatchSetInserter is the first affected commit. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 --- Comment #2 from christ...@quelltextlich.at --- I have not verified myself, but does this actually break things for Jenkins/Zuul, or is it just a “nuissance”? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60781] [upstream] Gerrit patchset-created event has been changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 Antoine "hashar" Musso changed: What|Removed |Added Keywords||upstream Priority|Unprioritized |High Summary|Gerrit patchset-created |[upstream] Gerrit |event has been changed |patchset-created event has ||been changed --- Comment #1 from Antoine "hashar" Musso --- Upstream bug: https://code.google.com/p/gerrit/issues/detail?id=2493 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
