[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #11 from Brion Vibber --- Ok, 8a336ddd9 from that last change set tweaks things so the initial 'NeedsToken' response doesn't include the captcha information. This means the user gets prompted for a captcha only after we've checked other fatal errors. Seems to work in testing. :D Will update docs. Be aware that this hasn't gone out live yet... Do we need an LD or just wait for it and make sure the apps handle the new mode? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #10 from Gerrit Notification Bot --- Change 118381 merged by Brion VIBBER: Return captcha information via createaccount API only if no other errors https://gerrit.wikimedia.org/r/118381 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #9 from Gerrit Notification Bot --- Change 118374 abandoned by MaxSem: Allow extensions modify API action=createaccount errors Reason: Ehm, not needed. https://gerrit.wikimedia.org/r/118374 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #8 from Gerrit Notification Bot --- Change 118381 had a related patch set uploaded by MaxSem: Return captcha information via createaccount API only if no other errors https://gerrit.wikimedia.org/r/118381 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #7 from Gerrit Notification Bot --- Change 118374 had a related patch set uploaded by MaxSem: Allow extensions modify API action=createaccount errors https://gerrit.wikimedia.org/r/118374 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704
Max Semenik changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
CC||maxsem.w...@gmail.com
--- Comment #6 from Max Semenik ---
After poking at it some more, what would fully help is to perform all checks
but token, then call AbortNewAccount, then check token and only then call some
new hook for ConfirmEdit ("AbortNewAccountForRealz"?). Simply adding extra data
to dieStatus() would result in clients having to handle two cases with
principally diffrent data structure: token is needed (normal return with
{createaccount:{result:"NeedsToken", captcha:...}}) and all other problems
({error:{...}}).
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #5 from Gerrit Notification Bot --- Change 116872 abandoned by MaxSem: action=createaccount should do checks in the first request, not second https://gerrit.wikimedia.org/r/116872 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #4 from Brad Jorsch --- Looking at this closer, I think the description of this bug is misleading. Which means comment 1 should be ignored, at least as far as ConfirmEdit goes. The problem isn't the order of the checks, it's that the captcha information is added at the "NeedToken" step (implying it needs to be solved there) and not in a later step. That should probably be the other way around. So what should really be happening is that ConfirmEdit shouldn't use the 'AddNewAccountApiResult' hook at all. Instead, the case in ApiCreateAccount handling a not-OK status should call some other hook function to populate an $extraData array (which ConfirmEdit would use to inject its captcha data), then call $this->getErrorFromStatus() and $this->dieUsage($msg, $code, 0, $extraData). Or we could add an $extraData parameter to ApiBase::dieStatus. And note you're probably still going to run into problems of this sort if there are multiple AbortNewAccount hook functions, since ConfirmEdit's might be run before the other extensions'. There's nothing the API can do about that, it would take redefining AbortNewAccount to still fail the creation when $abortStatus is non-OK even if the hook function returned true (and then probably deprecate returning non-true for that hook). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #3 from Gerrit Notification Bot --- Change 116872 had a related patch set uploaded by MaxSem: action=createaccount should do checks in the first request, not second https://gerrit.wikimedia.org/r/116872 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 Andre Klapper changed: What|Removed |Added Priority|Unprioritized |Normal Version|unspecified |1.23-git See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=34447 Severity|normal |enhancement --- Comment #2 from Andre Klapper --- Also see patch in bug 34447 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61704] action=createaccount should do checks in the first request, not second
https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 --- Comment #1 from Brad Jorsch --- If you want to refactor LoginForm::addNewaccountInternal() into a validation function and an actual creation function, feel free and I'll review it. Keep in mind that we'll most likely still want to run 'AddNewAccountApiForm' before 'AbortNewAccount'. But let's not duplicate all the checks in LoginForm::addNewaccountInternal() into ApiCreateAccount. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
