[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #22 from Bawolff (Brian Wolff) bawolff...@gmail.com --- This might be more appropriate for a separate bug - in that case, sorry for the offtopic discussion. Yeah it is kind of something that should be a separate bug. I started

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #20 from Tilman Bayer tba...@wikimedia.org --- (In reply to Bawolff (Brian Wolff) from comment #18) Yes, it was changed as a workaround for this bug last week. But that's actually the way we most often use for videos on the

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #21 from Bawolff (Brian Wolff) bawolff...@gmail.com --- However, when I tried this out, reusing the div class=mediaContainer ... HTML (from this wiki page: https://meta.wikimedia.org/w/index.php?title=Wikimedia_Blog/Drafts/

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #19 from Tisza Gergő gti...@wikimedia.org --- (In reply to Bawolff (Brian Wolff) from comment #18) I don't think there's a bug for that, but its been on my mind that there should be a method of specifying the thumbtime via iframe.

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #6

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #7 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to Tisza Gergő from comment #6) This seems to have made things worse, the blog posts are completely unreadable now. Oh wow. That's not good. Hmm, so this

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #8 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Ok, what's happening is that $wgBreakFrames = true is on production. My last change that used MW's default loader, caused this code to become active for embedplayer=yes -- You

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142085 had a related patch set uploaded by Brian Wolff: Do not break iframes in the iframe output of TMH https://gerrit.wikimedia.org/r/142085 -- You are

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #10 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to Bawolff (Brian Wolff) from comment #8) Ok, what's happening is that $wgBreakFrames = true is on production. My last change that used MW's default loader, caused

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142132 had a related patch set uploaded by Gergő Tisza: Do not break iframes in the iframe output of TMH https://gerrit.wikimedia.org/r/142132 -- You are

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142085 merged by jenkins-bot: Do not break iframes in the iframe output of TMH https://gerrit.wikimedia.org/r/142085 -- You are receiving this mail because:

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142132 merged by jenkins-bot: Do not break iframes in the iframe output of TMH https://gerrit.wikimedia.org/r/142132 -- You are receiving this mail because:

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142149 had a related patch set uploaded by Gergő Tisza: Update TimedMediaHandler with embed breakage fixes https://gerrit.wikimedia.org/r/142149 -- You are

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142149 merged by jenkins-bot: Update TimedMediaHandler with embed breakage fixes https://gerrit.wikimedia.org/r/142149 -- You are receiving this mail because:

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #17 from Tilman Bayer tba...@wikimedia.org --- (In reply to Tisza Gergő from comment #16) Fix deployed to Commons, seems to work now. Thanks, Bawolff! Great, works for me too now. Thanks a lot everyone, in particular Bawolff!

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #18 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Yes, it was changed as a workaround for this bug last week. But that's actually the way we most often use for videos on the blog (e.g.

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 137529 merged by jenkins-bot: Fix ?embedplayer=yes mode, which is currently totally broken https://gerrit.wikimedia.org/r/137529 -- You are receiving this mail

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #5 from Bawolff (Brian Wolff) bawolff...@gmail.com --- This should hopefully start working again come june 24. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added CC|

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High -- You

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 137529 had a related patch set uploaded by Brian Wolff: Fix ?embedplayer=yes mode, which is currently totally broken https://gerrit.wikimedia.org/r/137529 --

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 --- Comment #2 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Ugh. Really need to figure out how to do automated testing of this (selenium?) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list

[Bug 66143] ?embedplayer=yes videos broken (again)

https://bugzilla.wikimedia.org/show_bug.cgi?id=66143 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added Keywords|