https://bugzilla.wikimedia.org/show_bug.cgi?id=67815
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=67815
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=67815
--- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 145503 merged by jenkins-bot:
Avoid race condition in GlobalBlocking::insertBlock
https://gerrit.wikimedia.org/r/145503
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67815
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=67815
--- Comment #1 from Sam Reed (reedy) s...@reedyboy.net ---
(In reply to matanya from comment #0)
csteipp It does a check, then does the insert, so definitely a race
condition.
[19:08:34] legoktm well, the check we do before hand uses the
https://bugzilla.wikimedia.org/show_bug.cgi?id=67815
--- Comment #2 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Our check to see if there is already a block is currently using a slave.
Instead it should be using master.
Then, I'm thinking we should set 'IGNORE' on the insert
https://bugzilla.wikimedia.org/show_bug.cgi?id=67815
--- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 145503 had a related patch set uploaded by Legoktm:
Avoid race condition in GlobalBlocking::insertBlock
https://gerrit.wikimedia.org/r/145503
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=67815
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
