[Bug 68196] HHVM crash loading San Francisco page

2014-07-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 Giuseppe Lavagetto glavage...@wikimedia.org changed: What|Removed |Added Status|UNCONFIRMED

[Bug 68196] HHVM crash loading San Francisco page

2014-07-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 Bryan Davis bda...@wikimedia.org changed: What|Removed |Added CC||bda...@wikimedia.org

[Bug 68196] HHVM crash loading San Francisco page

2014-07-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #11 from Tim Starling tstarl...@wikimedia.org --- Nice work. A Lua error in an unprotected function like lua_pushcclosure() could indeed cause a longjmp to unwind HHVM's stack. If Lua was not in the stack when this happened, it

[Bug 68196] HHVM crash loading San Francisco page

2014-07-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #12 from Tim Starling tstarl...@wikimedia.org --- Also, because Lua is in the stack, the in_lua flag is set, so slop is zero. That is to say, the hack intended to fix bug 59130 is disabled. The Lua userspace takes the usage to

[Bug 68196] HHVM crash loading San Francisco page

2014-07-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #13 from Tim Starling tstarl...@wikimedia.org --- Created attachment 16028 -- https://bugzilla.wikimedia.org/attachment.cgi?id=16028action=edit Reduced test case I used a recursive table a = {a,0} to force Lua to do the small

[Bug 68196] HHVM crash loading San Francisco page

2014-07-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #14 from Tim Starling tstarl...@wikimedia.org --- On hhvm.256.io, I have installed a LuaSandbox statically linked against Lua compiled as C++. With this build, the reduced test case exits cleanly with Fatal error: unknown exception.

[Bug 68196] HHVM crash loading San Francisco page

2014-07-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #9 from Brett Simmers bsimm...@fb.com --- After some fun times with gdb, I'm almost certain this is luasandbox related, though I'm not yet sure what the root cause is. I was seeing what looked like some C++ frames disappearing

[Bug 68196] HHVM crash loading San Francisco page

2014-07-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #10 from Brett Simmers bsimm...@fb.com --- I don't know anything about the internals of the Zend engine. Is it possible that this is happening with PHP5 as well but everything happens to work out anyway? I'll try it tomorrow but

[Bug 68196] HHVM crash loading San Francisco page

2014-07-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #7 from Tim Starling tstarl...@wikimedia.org --- It is asserting while checking local number 7 of PPFrame_Hash::expand(). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the

[Bug 68196] HHVM crash loading San Francisco page

2014-07-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #8 from Tim Starling tstarl...@wikimedia.org --- ...that being $iteratorNode. The TypedValue* for $iteratorNode was consistent enough for me to set a watch on it, which showed it being overwritten with garbage by

[Bug 68196] HHVM crash loading San Francisco page

2014-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #1 from Brett Simmers bsimm...@fb.com --- ~bsimmers/lua.log has a much more useful-looking stacktrace than what we were previously seeing. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC

[Bug 68196] HHVM crash loading San Francisco page

2014-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 Ori Livneh o...@wikimedia.org changed: What|Removed |Added CC||o...@wikimedia.org ---

[Bug 68196] HHVM crash loading San Francisco page

2014-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 Max Semenik maxsem.w...@gmail.com changed: What|Removed |Added Attachment #15964|application/octet-stream|text/plain

[Bug 68196] HHVM crash loading San Francisco page

2014-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords||hiphop -- You

[Bug 68196] HHVM crash loading San Francisco page

2014-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #3 from Tim Starling tstarl...@wikimedia.org --- The backtrace suggests https://github.com/facebook/hhvm/pull/3121 , which I see you don't have the fix for in /home/bsimmers/hhvm-dbg . When I parse that page in CLI mode using

[Bug 68196] HHVM crash loading San Francisco page

2014-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #4 from Brett Simmers bsimm...@fb.com --- I tried with that applied earlier today and it still crashed (I've been messing with the contents of that working dir recently). I guess I didn't notice that it was a different crash. How

[Bug 68196] HHVM crash loading San Francisco page

2014-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #5 from Ori Livneh o...@wikimedia.org --- (In reply to Brett Simmers from comment #4) How can I parse a page in CLI mode? cd /srv/mediawiki php maintenance/eval.php $title = Title::newFromText('San Francisco'); $text =

[Bug 68196] HHVM crash loading San Francisco page

2014-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68196 --- Comment #6 from Tim Starling tstarl...@wikimedia.org --- Yes, that. There are various other ways to do it, but that one lets you modify the input text before you run it, which is often useful for isolating parser-related bugs. However, I