[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #104 from Bartosz Dziewoński matma@gmail.com --- It has been done a long time ago, see comment 72 and comment 77 and https://gerrit.wikimedia.org/r/#/c/163168/ and such. We couldn't delete them on master at the time because of fear of breaking on-wiki customizations. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #96 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 173417 had a related patch set uploaded by Bartosz Dziewoński: Delete skins/common/images/magnify-clip.png https://gerrit.wikimedia.org/r/173417 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bug 69277 depends on bug 69678, which changed state. Bug 69678 Summary: Track down popular gadgets that refer to files in skins/common/ and fix them not to https://bugzilla.wikimedia.org/show_bug.cgi?id=69678 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #97 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 173434 had a related patch set uploaded by Bartosz Dziewoński: Delete skins/common/images/bullet.gif https://gerrit.wikimedia.org/r/173434 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #98 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 172256 merged by jenkins-bot: Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}} https://gerrit.wikimedia.org/r/172256 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #99 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 173417 merged by jenkins-bot: Delete skins/common/images/magnify-clip.png https://gerrit.wikimedia.org/r/173417 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #100 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 173434 merged by jenkins-bot: Delete skins/common/images/bullet.gif https://gerrit.wikimedia.org/r/173434 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #101 from James Forrester jforres...@wikimedia.org --- Done. Gosh. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Version|1.25-git|1.24rc Target Milestone|--- |1.24.0 release --- Comment #102 from Bartosz Dziewoński matma@gmail.com --- And the directory is gone from master too! At last! Thank you, everyone who helped wit this boring cleanup work :D (MW 1.24 will also be released without it.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #103 from Mark A. Hershberger m...@everybody.org --- Rats. And I just sent out a note about not seeing any need to send out an RC this week. I'm sorry I missed this. Bartosz, could you cherry pick these to REL1_24 so they'll be ready next week? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added CC||m...@everybody.org Version|1.24rc |1.25-git Target Milestone|1.24.0 release |--- --- Comment #95 from Mark A. Hershberger m...@everybody.org --- This isn't really relevant to the release of 1.24.0 or the tarball in general as other bugs exist for dealing with it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #93 from Erwin Dokter er...@darcoury.nl --- (In reply to Bartosz Dziewoński from comment #90) No idea what the deal with Checker-16x16.png is now, let's ignore it, it can't be a very important asset anywhere. That is the backdrop for transparent images on file description pages, and often called from Common.css. Limiting this to data from 1.25wmfX and grouping, we get... Is this the entire WMF cluster, or just one wiki? If the first, the request can come from any project's Common.css. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #94 from Bartosz Dziewoński matma@gmail.com --- (In reply to Erwin Dokter from comment #93) (In reply to Bartosz Dziewoński from comment #90) No idea what the deal with Checker-16x16.png is now, let's ignore it, it can't be a very important asset anywhere. That is the backdrop for transparent images on file description pages, and often called from Common.css. I know what it is and where it used to be called. I only have no idea what the deal is with the thousands requests per day, as I went through the wikis a few weeks ago and replaced all of the references. Perhaps some bright soul decided to revert my changes somewhere. Limiting this to data from 1.25wmfX and grouping, we get... Is this the entire WMF cluster, or just one wiki? If the first, the request can come from any project's Common.css. The entire cluster. I am aware that the request can come from anywhere, and I've been tracking down and replacing these references in the past months. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #90 from Bartosz Dziewoński matma@gmail.com --- (In reply to Dan Andreescu from comment #83) Created attachment 16942 [details] hits to */skins/common/** on October 27th Limiting this to data from 1.25wmfX and grouping, we get: images/Checker-16x16.png 14826 images/magnify-clip.png 13622 images/bullet.gif 1407 images/closewindow19x19.png700 shared.css 250 wikibits.js152 images/spinner.gif 95 images/ajax-loader.gif 54 images/redirectltr.png 37 images/button_template.png 29 No idea what the deal with Checker-16x16.png is now, let's ignore it, it can't be a very important asset anywhere. Some more of these files are already deleted and get neglibigle number of requests. Getting rid of that, we have these stats for files that still exist: images/magnify-clip.png 13622 images/bullet.gif 1407 images/redirectltr.png 37 images/magnify-clip-rtl.png 0 images/redirectrtl.png 0 I'll spend some more time hunting down magnify-clip.png and bullet.gif, let's remove the rest already. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #91 from Bartosz Dziewoński matma@gmail.com --- Correction: images/magnify-clip.png 13622 images/bullet.gif 1407 wikibits.js152 images/redirectltr.png 37 images/magnify-clip-rtl.png 0 images/redirectrtl.png 0 ajax.js 0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #92 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 172256 had a related patch set uploaded by Bartosz Dziewoński: Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}} https://gerrit.wikimedia.org/r/172256 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #88 from Andre Klapper aklap...@wikimedia.org --- (In reply to Dan Andreescu from comment #86) Well, you can query the logs with SQL on our hadoop cluster if you'd like more info (you have rights to stat1002.eqiad.wmnet right Sam?) I mean, I could run queries for you I guess either Reedy needs to get access, or Dan could run those queries? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #89 from Dan Andreescu dandree...@wikimedia.org --- Sorry to not update the bug - RT ticket has been filed to get Sam access: https://rt.wikimedia.org/Ticket/Display.html?id=8773 I don't have access to see it, but I can follow up if it hasn't been resolved. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #83 from Dan Andreescu dandree...@wikimedia.org --- Created attachment 16942 -- https://bugzilla.wikimedia.org/attachment.cgi?id=16942action=edit hits to */skins/common/** on October 27th -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #84 from Sam Reed (reedy) s...@reedyboy.net --- wtf /static-1.21wmf10/skins/common/images/magnify-clip.png14926 /static-1.21wmf8/skins/common/images/magnify-clip.png11160 All these links to ancient mediawiki dirs... -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #85 from Sam Reed (reedy) s...@reedyboy.net --- (In reply to Dan Andreescu from comment #83) Created attachment 16942 [details] hits to */skins/common/** on October 27th Are you able to tell us where these requests are coming from? A lot of those are long long dead urls... I presume they're 404-ing -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #86 from Dan Andreescu dandree...@wikimedia.org --- Well, you can query the logs with SQL on our hadoop cluster if you'd like more info (you have rights to stat1002.eqiad.wmnet right Sam?) I mean, I could run queries for you but it sounds like you just want to investigate. For example, to get a breakdown by status, you could do: sta1002 hive hive (default) use wmf_raw; hive (wmf_raw) select uri_path, http_status, count(*) from webrequest where webrequest_source='bits' and year=2014 and month=10 and day=28 and uri_path like '%skins/common/%' group by uri_path, http_status having count(*) 20 ; You can see what else is available (like referrer) with: hive (wmf_raw) describe webrequest; If you just want to poke around smaller bits of data, you can add something like and hour=12. Without that, the query above could take over an hour. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #87 from Sam Reed (reedy) s...@reedyboy.net --- reedy@tin:/srv/mediawiki-staging$ ssh -A stat1002 Permission denied (publickey). reedy@tin:/srv/mediawiki-staging$ Nope :( -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #82 from Krinkle krinklem...@gmail.com --- Be sure to account for: bits.wikimedia.org {wiki domain}.org paths: - skins - skins-1.5 static-{mwversion|current}/skins e.g. http://en.wikipedia.org/w/skins-1.5/ http://en.wikipedia.org/w/skins/ http://en.wikipedia.org/w/static-1.25wmf1/skins/ http://bits.wikimedia.org/skins-1.5/ http://bits.wikimedia.org/skins/ http://bits.wikimedia.org/static-current/skins/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #80 from Bartosz Dziewoński matma@gmail.com --- (In reply to Dan Andreescu from comment #62) Created attachment 16507 [details] hits to */skins/common/** on September 16th (I did look at this, but it just so happened that the changes I was specifically interested in evaluating didn't go into production soon enough for this to contain data useful for me :( ) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #81 from Dan Andreescu dandree...@wikimedia.org --- Bartosz, let me know if you need another run at some point. If I don't answer just ping me on IRC (milimetric in #wikimedia-analytics). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #78 from Erwin Dokter er...@darcoury.nl --- Where will bullet.gif end up? Please don't tell me it depends or anything like that... Monobook (as does Common.css) still needs this and I cannot trace where it has been/will be moved. I absolutely need to know. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #79 from Erwin Dokter er...@darcoury.nl --- Never mind... found it in /skins/MonoBook. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #69 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 163168 had a related patch set uploaded by Bartosz Dziewoński: Delete skins/common/ https://gerrit.wikimedia.org/r/163168 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #71 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 163171 had a related patch set uploaded by Bartosz Dziewoński: Add release notes for skins/common/ removal https://gerrit.wikimedia.org/r/163171 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #70 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 163169 had a related patch set uploaded by Bartosz Dziewoński: Add release notes for skins/common/ removal https://gerrit.wikimedia.org/r/163169 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #72 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 163168 merged by Bartosz Dziewoński: Delete skins/common/ https://gerrit.wikimedia.org/r/163168 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #73 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 163210 had a related patch set uploaded by Paladox: Delete skins/common/ https://gerrit.wikimedia.org/r/163210 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #74 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 163210 abandoned by Paladox: Delete skins/common/ https://gerrit.wikimedia.org/r/163210 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #75 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 163171 merged by jenkins-bot: Add release notes for skins/common/ removal https://gerrit.wikimedia.org/r/163171 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #76 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 163169 merged by jenkins-bot: Add release notes for skins/common/ removal https://gerrit.wikimedia.org/r/163169 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED --- Comment #77 from Bartosz Dziewoński matma@gmail.com --- (In reply to Bartosz Dziewoński from comment #59) Release notes listing what exactly was removed Done for 1.24 and synchronised on master, see above. Remove the stray files in skins/common/ that are waiting for caches to expire Removed for 1.24, see above. Will do so on master, too, but only after finishing with bug 69678. I think this is the only thing remaining before we can finally close this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #68 from Waldir wal...@email.com --- (In reply to James Forrester from comment #67) Still a few files left to go… Link for convenience: http://git.wikimedia.org/tree/mediawiki%2Fcore.git/HEAD/skins%2Fcommon -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #64 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 161770 had a related patch set uploaded by Legoktm: Move default logo to resources/assets/ directory https://gerrit.wikimedia.org/r/161770 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #66 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 161770 merged by jenkins-bot: Move default logo to resources/assets/ directory https://gerrit.wikimedia.org/r/161770 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #65 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 159290 merged by jenkins-bot: Move default logo to resources/assets/ directory https://gerrit.wikimedia.org/r/159290 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED --- Comment #67 from James Forrester jforres...@wikimedia.org --- Still a few files left to go… -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bug 69277 depends on bug 69673, which changed state. Bug 69673 Summary: Stop using inline img for thumbnail magnify icon https://bugzilla.wikimedia.org/show_bug.cgi?id=69673 What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bug 69277 depends on bug 69673, which changed state. Bug 69673 Summary: Stop using inline img for thumbnail magnify icon https://bugzilla.wikimedia.org/show_bug.cgi?id=69673 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #63 from Bartosz Dziewoński matma@gmail.com --- (The assets/ directory has been renamed to resources/assets/ in 1cf5a6e9.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #60 from Dan Andreescu dandree...@wikimedia.org --- I ran the query again for September 16th, but I got some fairly detailed URLs that I'm not sure I should post. I'm checking with some people and I'll post if they think it's ok. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #62 from Dan Andreescu dandree...@wikimedia.org --- Created attachment 16507 -- https://bugzilla.wikimedia.org/attachment.cgi?id=16507action=edit hits to */skins/common/** on September 16th -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #61 from Dan Andreescu dandree...@wikimedia.org --- I'm posting the file. I just redacted all results that had = 20 hits. There were some weird, overly-specific URLs in there. I left everything as it came back from my query: https://bugzilla.wikimedia.org/show_bug.cgi?id=69277#c8 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #57 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155442 merged by jenkins-bot: Revamp classic edit toolbar not to hardcode paths in HTML https://gerrit.wikimedia.org/r/155442 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bug 69277 depends on bug 70615, which changed state. Bug 70615 Summary: Fix extensions depending on skins/common/ https://bugzilla.wikimedia.org/show_bug.cgi?id=70615 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #58 from James Forrester jforres...@wikimedia.org --- Last remaining item in gerrit is https://gerrit.wikimedia.org/r/#/c/159290/ per https://gerrit.wikimedia.org/r/#/q/bug:69277,n,z – then just gadgets. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED --- Comment #59 from Bartosz Dziewoński matma@gmail.com --- (In reply to James Forrester from comment #58) Last remaining item in gerrit is https://gerrit.wikimedia.org/r/#/c/159290/ Yup, also remaining to do: * Remove the stray files in skins/common/ that are waiting for caches to expire * Release notes listing what exactly was removed then just gadgets. I've been trying to mwgrep as I was moving/deleting files and this seems to be a much lesser issue than I anticipated. Unless I missed something, the only files that still need action are bullet.gif and possibly wikibits.js. It's been about a month, so I asked Dan to re-run the query from comment 8. I wonder how the request counts have changed with the patches that have already been deployed. There are probably still many requests now, but hopefully when we re-run it again next month the numbers will hover around zero. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #56 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158650 merged by jenkins-bot: Move footer icons to assets/ directory https://gerrit.wikimedia.org/r/158650 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #55 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 159290 had a related patch set uploaded by Bartosz Dziewoński: Move default logo to assets/ directory https://gerrit.wikimedia.org/r/159290 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Depends on||70615 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bug 69277 depends on bug 70412, which changed state. Bug 70412 Summary: LQT: [Regression 1.24wmf20] Pagination arrows have been moved https://bugzilla.wikimedia.org/show_bug.cgi?id=70412 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |matma@gmail.com |org | Target Milestone|--- |1.24.0 release -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #51 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158649 merged by jenkins-bot: Move mediawiki.png to assets/ directory https://gerrit.wikimedia.org/r/158649 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #50 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158648 merged by jenkins-bot: Move file type icons to new assets/ directory https://gerrit.wikimedia.org/r/158648 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #52 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158627 merged by jenkins-bot: Article: Don't hardcode img tags on redirect page https://gerrit.wikimedia.org/r/158627 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #53 from James Forrester jforres...@wikimedia.org --- Now down to two: https://gerrit.wikimedia.org/r/#/q/bug:69277+status:open,n,z -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #54 from Bartosz Dziewoński matma@gmail.com --- I put up a note on the release page: [[mw:MediaWiki 1.24#Directory changes]]. Haven't updated RELEASE-NOTES-1.24 yet. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #45 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158627 had a related patch set uploaded by Bartosz Dziewoński: Article: Don't hardcode img tags on redirect page https://gerrit.wikimedia.org/r/158627 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #46 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158648 had a related patch set uploaded by Bartosz Dziewoński: Move file type icons to new assets/ directory https://gerrit.wikimedia.org/r/158648 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #47 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158649 had a related patch set uploaded by Bartosz Dziewoński: Move mediawiki.png to assets/ directory https://gerrit.wikimedia.org/r/158649 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #48 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158650 had a related patch set uploaded by Bartosz Dziewoński: Move remaining skin files to assets/ directory https://gerrit.wikimedia.org/r/158650 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #49 from Bartosz Dziewoński matma@gmail.com --- And with this, I have patches pending or merged to make MediaWiki stop using skins/common/ entirely. What remains is getting the remaining copies of files actually deleted, and probably fixing up some unavoidable bugs. Patches relevant to this bug that are still pending: * Revamp classic edit toolbar not to hardcode paths in HTML https://gerrit.wikimedia.org/r/155442 * Article: Don't hardcode img tags on redirect page https://gerrit.wikimedia.org/r/158627 * Move file type icons to new assets/ directory https://gerrit.wikimedia.org/r/158648 * Move mediawiki.png to assets/ directory https://gerrit.wikimedia.org/r/158649 * Move remaining skin files to assets/ directory https://gerrit.wikimedia.org/r/158650 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #44 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 157490 merged by jenkins-bot: Move mediawiki.skinning.* modules from skins/common/ to resources/ https://gerrit.wikimedia.org/r/157490 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed: What|Removed |Added Depends on||70412 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #42 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158091 had a related patch set uploaded by Bartosz Dziewoński: Delete closewindow19x19.png https://gerrit.wikimedia.org/r/158091 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #43 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 158091 merged by jenkins-bot: Delete skins/common/images/closewindow19x19.png https://gerrit.wikimedia.org/r/158091 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #38 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 153370 merged by jenkins-bot: Move mediawiki.legacy.* modules from skins/common/ to resources/ https://gerrit.wikimedia.org/r/153370 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #39 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155910 merged by jenkins-bot: TablePager: Load images via CSS backgrounds rather than HTML imgs https://gerrit.wikimedia.org/r/155910 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #40 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155914 merged by Bartosz Dziewoński: TablePager: Redo arrow icons from scratch as CSS backgrounds https://gerrit.wikimedia.org/r/155914 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #41 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 157490 had a related patch set uploaded by Bartosz Dziewoński: Move mediawiki.skinning.* modules from skins/common/ to resources/ https://gerrit.wikimedia.org/r/157490 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #36 from Bartosz Dziewoński matma@gmail.com --- (In reply to Marcin Cieślak from comment #35) Seems like a slight botched preparation of the mediawiki/skins project :( Indeed :( There are limits to what one person can do. Frankly I think it's a wasted effort here. Some files have been here nearly forever and I am not sure it is worth chasing links to those resources. This bug, and the patches, are not really about chasing links (although I fix the important ones) but about just moving the files elsewhere. As you can see, it's taking surprisingly long, because, again, I'm the only person working on it and no one wants to review patches like that. Cool URIs do not change :) - just provide 302 redirects instead, if you really need to move them. From comment 26: Perhaps you could convince ops to keep the old URLs valid in some way, but I'm not going to try convincing anyone it's a good idea :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #37 from Marcin Cieślak marcin.cies...@gmail.com --- (In reply to Bartosz Dziewoński from comment #36) (In reply to Marcin Cieślak from comment #35) Seems like a slight botched preparation of the mediawiki/skins project :( Indeed :( There are limits to what one person can do. Frankly I think it's a wasted effort here. Some files have been here nearly forever and I am not sure it is worth chasing links to those resources. This bug, and the patches, are not really about chasing links (although I fix the important ones) but about just moving the files elsewhere. As you can see, it's taking surprisingly long, because, again, I'm the only person working on it and no one wants to review patches like that. That's why I think bug 69678 is not worth your time, really (but I'm not the one to judge it). Cool URIs do not change :) - just provide 302 redirects instead, if you really need to move them. From comment 26: Perhaps you could convince ops to keep the old URLs valid in some way, but I'm not going to try convincing anyone it's a good idea :) Personally I am fine with the symlink solution and I'd close all of it as WONTFIX. Or maybe why not MediaWiki search for skins also in some other directory, say /w/skins-ext (or whatever the name) and leave /w/skins/common in peace. What do you think? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #32 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 156292 had a related patch set uploaded by Bartosz Dziewoński: Delete feed.css https://gerrit.wikimedia.org/r/156292 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #33 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155771 abandoned by Bartosz Dziewoński: Move feed.css to resources/, introduce resources/src/assets/ Reason: I'll revisit the 'assets' directory idea later. Not overwriting this patch so that I can refer to the discussion from elsewhere. https://gerrit.wikimedia.org/r/155771 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #34 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 156292 merged by jenkins-bot: Delete feed.css https://gerrit.wikimedia.org/r/156292 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Marcin Cieślak marcin.cies...@gmail.com changed: What|Removed |Added CC||marcin.cies...@gmail.com --- Comment #35 from Marcin Cieślak marcin.cies...@gmail.com --- Seems like a slight botched preparation of the mediawiki/skins project :( Frankly I think it's a wasted effort here. Some files have been here nearly forever and I am not sure it is worth chasing links to those resources. Cool URIs do not change :) - just provide 302 redirects instead, if you really need to move them. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #29 from Michael M. listenle...@gmail.com --- (In reply to Erwin Dokter from comment #27) Commons files are no more stable; the ones without protection are vulnerable to vandalism. I do consider the local paths to be safer then Commons. So please... where are they going? If the gadget doesn't have to support IE 7 and the image is small enough, using data URIs is also an option. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #30 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155910 had a related patch set uploaded by Bartosz Dziewoński: TablePager: Load images via CSS backgrounds rather than HTML imgs https://gerrit.wikimedia.org/r/155910 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #31 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155914 had a related patch set uploaded by Bartosz Dziewoński: TablePager: Redo arrow icons from scratch as CSS backgrounds https://gerrit.wikimedia.org/r/155914 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added CC||er...@darcoury.nl --- Comment #22 from Erwin Dokter er...@darcoury.nl --- Where are the images going to end up from Wikipedia's viewpoint? Many userscripts and gadgets also depend on it so I'd like a heads up when the location is known. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #23 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- (In reply to Erwin Dokter from comment #22) Where are the images going to end up from Wikipedia's viewpoint? Many userscripts and gadgets also depend on it so I'd like a heads up when the location is known. Commons usually. Bartosz has been using mwgrep to check if the images are used in sitewide CSS/JS, and updating the urls of those that are. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #24 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155771 had a related patch set uploaded by Bartosz Dziewoński: Move feed.css to resources/ https://gerrit.wikimedia.org/r/155771 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #25 from Erwin Dokter er...@darcoury.nl --- (In reply to Kunal Mehta (Legoktm) from comment #23) Commons usually. Bartosz has been using mwgrep to check if the images are used in sitewide CSS/JS, and updating the urls of those that are. That is not what I ment. I can't rely on Common as it does not have all the skin images. Right now, I can call the images locally in /w/skins/common/images/. Where are they going to be moved to from the viewpoint of the local installation? Will it be /w/resources/common/images/? Or perhaps /w/resources/skins/common/images/? Or may we perhaps have symbolic links mapping to their new location? Just a very simple question. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #26 from Bartosz Dziewoński matma@gmail.com --- (In reply to Erwin Dokter from comment #25) Where are they going to be moved to from the viewpoint of the local installation? Will it be /w/resources/common/images/? Or perhaps /w/resources/skins/common/images/? Nowhere. It's irrelevant. The paths to files are *not* stable and should not be relied on. (The old ones in skins/common/ were an exception.) So far I've been able to find all of the files I removed on Wikimedia Commons (https://commons.wikimedia.org/), under the same filenames too. If there is anything that's used by on-wiki scripts and isn't there, it should be uploaded there (and I will upload it if I run into anything). Or may we perhaps have symbolic links mapping to their new location? MediaWiki supports Windows hosts too, which don't support UNIX-style symbolic links, so we can't do that in the main repository. Perhaps you could convince ops to keep the old URLs valid in some way, but I'm not going to try convincing anyone it's a good idea :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #27 from Erwin Dokter er...@darcoury.nl --- (In reply to Bartosz Dziewoński from comment #26) Nowhere. It's irrelevant. The paths to files are *not* stable and should not be relied on. (The old ones in skins/common/ were an exception.) Commons files are no more stable; the ones without protection are vulnerable to vandalism. I do consider the local paths to be safer then Commons. So please... where are they going? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #28 from Bartosz Dziewoński matma@gmail.com --- (In reply to Erwin Dokter from comment #27) Commons files are no more stable; the ones without protection are vulnerable to vandalism. I do consider the local paths to be safer then Commons. So please... where are they going? It depends on the image; I'm trying to move them somewhere that makes sense. Generally somewhere under resources/. Some, which were unused (both in extensions and on Wikimedia wikis, as far as I could tell), were also removed entirely. I intend to make a list and add it to release notes; I was planning to do that later (would make it easier to have several independent patches pending review at the same time), but I guess I can do that now (later today). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155631 had a related patch set uploaded by Bartosz Dziewoński: Delete skins/common/images/button_template.png https://gerrit.wikimedia.org/r/155631 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #21 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155631 merged by jenkins-bot: Delete skins/common/images/button_template.png https://gerrit.wikimedia.org/r/155631 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #18 from Michael M. listenle...@gmail.com --- (In reply to Bartosz Dziewoński from comment #12) images/bullet.gif28780 This is surprising, none of our code seems to refer to it. Needs investigating. [[MediaWiki:Common.css]] uses this (and perhaps other wiki styles, too). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155442 had a related patch set uploaded by Bartosz Dziewoński: Revamp classic edit toolbar not to hardcode paths in HTML https://gerrit.wikimedia.org/r/155442 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69277] Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else
https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 153368 merged by jenkins-bot: Move installer files from skins/common/ to mw-config/ https://gerrit.wikimedia.org/r/153368 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l