https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Bartosz Dziewoński matma@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Prateek Saxena psax...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 167628 had a related patch set uploaded by Mattflaschen:
Revert Add maxlength of 6 for time correction in preferences
https://gerrit.wikimedia.org/r/167628
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 167628 merged by jenkins-bot:
Revert Add maxlength of 6 for time correction in preferences
https://gerrit.wikimedia.org/r/167628
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Matthew Flaschen mflasc...@wikimedia.org changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #15 from Jon jrob...@wikimedia.org ---
How do we want to deal with the size visually?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 161421 merged by jenkins-bot:
Add maxlength of 6 for time correction in preferences
https://gerrit.wikimedia.org/r/161421
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Blocks||70913
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Prateek Saxena psax...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #8 from Matthew Flaschen mflasc...@wikimedia.org ---
No, this is not a number. Anyway, I have concerns about the idea of using
maxlength for input type=number (see bug 70973).
--
You are receiving this mail because:
You are the
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #9 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org ---
What are your concerns Matt? If the form only accepts certain inputs why should
we allow users to create input that will result in an error 100% of the time
?
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #10 from Matthew Flaschen mflasc...@wikimedia.org ---
(In reply to Jared Zimmerman (WMF) from comment #9)
What are your concerns Matt? If the form only accepts certain inputs why
should we allow users to create input that will
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #11 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org ---
Does that mean that phone number and credit card fields that limit both
characters and string length are using JavaScript for client side form
validation rather than
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 161421 had a related patch set uploaded by Mattflaschen:
Add maxlength of 6 for time correction in preferences
https://gerrit.wikimedia.org/r/161421
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #13 from Matthew Flaschen mflasc...@wikimedia.org ---
We're already using input[type=text] here, so we can add the maxlength here, as
long as we know what the right value is. I looked into it, and it seems 6 is
safe, as you said.
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
--- Comment #14 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org ---
Thanks Matt, very illuminating.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Matthew Flaschen mflasc...@wikimedia.org changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=70405
Matthew Flaschen mflasc...@wikimedia.org changed:
What|Removed |Added
Summary|Appearance Time offset
23 matches
Mail list logo
