[Bug 72345] HTML tidy not executed under HHVM; messes up page layouts

2014-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=72345

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||g...@wikimedia.org
Summary|HTML tidy not executed  |HTML tidy not executed
   |under HHVM  |under HHVM; messes up page
   ||layouts

--- Comment #3 from Andre Klapper aklap...@wikimedia.org ---
Issue was also brought up on de.wp:
https://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipediaoldid=13512#Software.C3.A4nderung.3F

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 72345] HTML tidy not executed under HHVM; messes up page layouts

2014-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=72345

--- Comment #4 from Michael M. listenle...@gmail.com ---
(In reply to darkdadaah from comment #2)
 The same issue occurs in a template in fr.wiktionary with HHVM enabled:
 https://fr.wiktionary.org/w/index.php?title=Mod%C3%A8le:de-nom-f-
 ndiff=prevoldid=18645452
 
 Although I can't find an incorrect tag, because the template in question is
 a bit complicated.

This is caused by Modèle:de-nom-f-n/Documentation: It contains multiple
selfclosing div / tags, but these are invalid in HTML. If you want the
documentation to display correctly even when HTML tidy doesn't work, you have
to replace them by div/div (I won't be able to give an appropriate French
summary for such an edit, so I can't fix it).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 72345] HTML tidy not executed under HHVM; messes up page layouts

2014-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=72345

Kevin Israel (PleaseStand) pleasest...@live.com changed:

   What|Removed |Added

 CC||pleasest...@live.com

--- Comment #5 from Kevin Israel (PleaseStand) pleasest...@live.com ---
This also appears to be the cause of bug 72343.

Also, as I noted there, not all servers seem to be affected, and I see a Tidy
was unable to run HTML comment in the output.

Assuming that $wgTidyInternal is false (by default, this is the case if
extension_loaded( 'tidy' ) returns false), it looks like this can only happen
if proc_open() or proc_close() fails when called from
MWTidy::execExternalTidy().

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 72345] HTML tidy not executed under HHVM; messes up page layouts

2014-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=72345

--- Comment #6 from Dakdada darkdad...@yahoo.fr ---
Michael M.: thanks, the page has been corrected.

I keep here a link to the previous buggy version of the page for future tests
(if needed):
https://fr.wiktionary.org/w/index.php?title=Mod%C3%A8le:de-nom-f-n/Documentationoldid=18183655

Also, the html source of the erroneous page contains the message: Tidy was
unable to run. Not that there is any doubt about it now...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 72345] HTML tidy not executed under HHVM; messes up page layouts

2014-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=72345

Umherirrender umherirrender_de...@web.de changed:

   What|Removed |Added

 CC||ril...@wikipedia.de

--- Comment #7 from Umherirrender umherirrender_de...@web.de ---
*** Bug 72357 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 72345] HTML tidy not executed under HHVM; messes up page layouts

2014-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=72345

--- Comment #9 from Brad Jorsch bjor...@wikimedia.org ---
Copying my analysis from bug 72357:

This appears to be bug 72205 (or more correctly, the memory leak in HHVM that
bug 72205 exacerbates[1]) filling up memory on the HHVM servers, which is
eventually causing the attempt to fork Tidy to fail, which is allowing
unbalanced tags in certain pages to corrupt the layout.

[1]: https://phabricator.wikimedia.org/T757

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 72345] HTML tidy not executed under HHVM; messes up page layouts

2014-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=72345

Brad Jorsch bjor...@wikimedia.org changed:

   What|Removed |Added

 CC||stradb...@gmail.com

--- Comment #8 from Brad Jorsch bjor...@wikimedia.org ---
*** Bug 72343 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l