[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 ✓ andbe...@web.de changed: What|Removed |Added Status|RESOLVED|REOPENED CC||andbe...@web.de Resolution|FIXED | --- Comment #5 from ✓ andbe...@web.de 2011-02-10 15:43:08 UTC --- Nice, I just tested it at translatewiki. Was it intended that the textalign an direction can be overwritten? textalign would be OK, but dir=rtl results in dir=ltr rtl which causes funny behavior at rtl-wikis. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 --- Comment #6 from Reedy s...@reedyboy.net 2011-02-10 16:21:33 UTC --- Hmm. The dir=ltr is only set in one case. Is it worth just checking if it's not been set, and then only conditionally set it? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081
--- Comment #7 from ✓ andbe...@web.de 2011-02-10 16:59:37 UTC ---
Are there any sources that can be rtl? I can't think of any programming
languages, but theres still lang=text.
I think we can ignore that cases (we already did it in the past), so either
if( isset( $attribs[$name] $name != 'dir') ) {
or better
$attribs['dir'] = 'ltr';
could be changed. The other way, allowing a custom direction, could be provided
by
$attribs['dir'] = $attribs['dir'] || 'ltr';
(Ive got no SVN, sorry)
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 --- Comment #8 from Reedy s...@reedyboy.net 2011-02-10 17:17:35 UTC --- Sorry, that's a bit hard to follow. Can you just write out the full code block? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081
--- Comment #9 from ✓ andbe...@web.de 2011-02-10 17:52:02 UTC ---
if ( $enclose === GESHI_HEADER_NONE ) {
$attribs = self::addAttribute( $attribs, 'class', 'mw-geshi ' . $lang .
' source-' . $lang );
} else {
- $attribs = self::addAttribute( $attribs, 'dir', 'ltr' );
+ $attribs['dir'] = $attribs['dir'] || 'ltr';
$attribs = self::addAttribute( $attribs, 'class', 'mw-geshi' );
$attribs = self::addAttribute( $attribs, 'style', 'text-align: left;' );
}
Im not sure whether PHP handles this automatic typecasting right, a more
detailed version would be
+ if ( is_null($attribs['dir']) ) $attribs['dir'] = 'ltr';
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081
--- Comment #10 from Reedy s...@reedyboy.net 2011-02-11 00:28:30 UTC ---
if ( !isset( $attribs['dir'] ) ) {
$attribs['dir'] = 'ltr';
}
I suppose...
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 Reedy s...@reedyboy.net changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #11 from Reedy s...@reedyboy.net 2011-02-11 00:31:28 UTC --- r81925 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 Reedy s...@reedyboy.net changed: What|Removed |Added Status|NEW |RESOLVED CC||s...@reedyboy.net Resolution||FIXED --- Comment #4 from Reedy s...@reedyboy.net 2011-02-10 01:59:38 UTC --- r81865 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC|krinklem...@gmail.com | AssignedTo|wikibugs-l@lists.wikimedia. |soxre...@gmail.com |org | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 --- Comment #3 from Umherirrender umherirrender_de...@web.de 2010-10-23 19:15:51 UTC --- Created attachment 7751 -- https://bugzilla.wikimedia.org/attachment.cgi?id=7751 allow params for source-tags I have create a patch, but I am not sure, if that the best way. Feel free to modify or create a new one. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Keywords||patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 --- Comment #2 from Chris Cunningham sexyeuro...@gmail.com 2010-08-27 11:41:24 UTC --- Any traction on this? Reasonably simple request for a simple gain. - Chris -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10081] Allow html attribute on SyntaxHighlight GeSHi extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=10081 MZMcBride pub...@mzmcbride.com changed: What|Removed |Added Keywords||bugday -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
