[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 Sam Reed (reedy) changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #19 from Sam Reed (reedy) 2012-05-10 03:34:15 UTC --- *** This bug has been marked as a duplicate of bug 22939 *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 Mark A. Hershberger changed: What|Removed |Added CC||m...@everybody.org --- Comment #18 from Mark A. Hershberger 2011-10-16 15:23:01 UTC --- (In reply to comment #17) > (In reply to comment #16) > > The images with ' in the title (see comment 3) appear to still exist in > > the image table, so I guess there's still an issue. r45387 would've fixed > > it, > > but Brion reverted it and apparently nobody ever got around to either > > unreverting it or committing the alternative fix Brion suggested. > > http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Sanitizer.php?view=annotate#l75 > > r89681 > > So brion did fix it... > > So it's in 1.18 Does cleanupImages need to be run anywhere? Is there anything else that needs to happen? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #17 from Reedy 2011-10-15 21:45:44 UTC --- (In reply to comment #16) > The images with ' in the title (see comment 3) appear to still exist in > the image table, so I guess there's still an issue. r45387 would've fixed it, > but Brion reverted it and apparently nobody ever got around to either > unreverting it or committing the alternative fix Brion suggested. http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Sanitizer.php?view=annotate#l75 r89681 So brion did fix it... So it's in 1.18 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #16 from Ilmari Karonen 2011-07-17 21:29:59 UTC --- The images with ' in the title (see comment 3) appear to still exist in the image table, so I guess there's still an issue. r45387 would've fixed it, but Brion reverted it and apparently nobody ever got around to either unreverting it or committing the alternative fix Brion suggested. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #15 from Reedy 2011-07-17 21:12:26 UTC --- What's the state of this then? cleanupImages in it's current incarnation finds no issues... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #14 from Aryeh Gregor 2010-08-13 17:28:50 UTC --- Yeah, confirmed, IE doesn't accept ', even IE8 with . -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 entli...@gmx-topmail.de changed: What|Removed |Added CC||entli...@gmx-topmail.de --- Comment #13 from entli...@gmx-topmail.de 2010-08-13 10:03:55 UTC --- ' is not valid XHTML per se; it's only usable in XHTML because XHTML is supposed to be XML, and XHTML is XML only if served with an XML mime type. If served as text/html, it's just the version of HTML that the browser supports (i.e. still HTML4 in many cases) sugared with some invalid XMLisms that the browser may or may not support - see http://www.w3.org/TR/xhtml1/#C_16. Mozilla, Opera and Webkit accept ' in HTML anyway (maybe because it is valid HTML5), but IE versions 6, 7 and 8 do not. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 Brion Vibber changed: What|Removed |Added Blocks||16660 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #12 from Aryeh Gregor 2009-01-07 06:24:49 UTC --- Because that's uglier, maybe? It should be simple enough to test ' in various browsers and see which work, anyway. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #11 from Ilmari Karonen 2009-01-07 06:03:13 UTC --- I've tried searching for a browser compatibility table for ', but haven't found any so far. Anyway, XHTML has existed for almost a decade now, so I suspect only very old browsers would be completely unaware of it. The IE behavior worries me more: one page I found, http://seewhatever.de/blog/?p=114 , says even IE 7 won't recognize ' in HTML mode, and seems to suggest that it's the MIME type that makes the difference. Anyway, why do we output named character entities at all? We already have a table of the Unicode code points corresponding to all of them, so it would be trivial to make normalizeEntity() output numeric entities only. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #10 from Aryeh Gregor 2009-01-07 05:05:45 UTC --- We always serve with an XHTML doctype, so that's not an issue. What browsers won't recognize it? Are we talking like NN4 here, or like IE6? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #9 from Ilmari Karonen 2009-01-07 04:35:44 UTC --- If we add ' to $wgHtmlEntities, the Sanitizer will allow it through normalizeCharReferences(). This could cause inconsistent rendering on old browsers that predate XHTML, or apparently even on some rather modern versions of IE if the page is served with a doctype (or maybe MIME type?) indicating HTML4 rather than XHTML. See e.g. http://cssvault.com/blog/2007/10/17/internet-explorer-apos-feature/ Still, we claim to be serving XHTML, so I suppose this should not be a problem (even if I do believe we're serving it with a "text/html" MIME type). And even on old browsers that don't support it, all that's likely to happen is that it'll be rendered verbatim (as indeed the sanitizer currently forces it to be). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 Brion Vibber changed: What|Removed |Added CC||br...@wikimedia.org --- Comment #8 from Brion Vibber 2009-01-07 02:33:11 UTC --- Reverted in r45477 as the special casing seems totally unnecessary... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 Aryeh Gregor changed: What|Removed |Added CC||simetrical+wikib...@gmail.co ||m --- Comment #7 from Aryeh Gregor 2009-01-04 18:57:26 UTC --- (In reply to comment #6) > The Picswiss files have been fixed now, but the ones with ' are still > broken, apparently because Sanitizer::decodeCharReferences() doesn't recognize > it. I've committed a fix in r45387 -- it's a bit ugly due to the special > status of ' as the only named character entity defined in XHTML 1.0 but > not in HTML 4.01. Why do we care about HTML 4.01? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 --- Comment #6 from Ilmari Karonen 2009-01-04 02:29:37 UTC --- The Picswiss files have been fixed now, but the ones with ' are still broken, apparently because Sanitizer::decodeCharReferences() doesn't recognize it. I've committed a fix in r45387 -- it's a bit ugly due to the special status of ' as the only named character entity defined in XHTML 1.0 but not in HTML 4.01. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 Brion Vibber <[EMAIL PROTECTED]> changed: What|Removed |Added Keywords||shell -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14365] Entries in the image table with invalid titles
https://bugzilla.wikimedia.org/show_bug.cgi?id=14365 Ilmari Karonen <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Severity|major |normal --- Comment #5 from Ilmari Karonen <[EMAIL PROTECTED]> 2008-12-09 23:24:10 UTC --- The fatal error should be fixed by r44370: now those titles are simply skipped. Actually fixing them requires running maintenance/cleanupImages.php. Reducing priority back to normal. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
