[Bug 15129] CheckUser Api Module

2011-10-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

John Du Hart j...@compwhizii.net changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||j...@compwhizii.net
 Resolution||DUPLICATE

--- Comment #30 from John Du Hart j...@compwhizii.net 2011-10-19 09:46:55 UTC 
---
Solved in Bug 31723

*** This bug has been marked as a duplicate of bug 31723 ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-10-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Bryan Tong Minh bryan.tongm...@gmail.com changed:

   What|Removed |Added

 CC||cryptocoryn...@gmail.com

--- Comment #29 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-10-15 
09:47:42 UTC ---
*** Bug 31723 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

--- Comment #26 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-05-24 
08:38:32 UTC ---
Except for the second one, my comments in #13 were not addressed:
 A few general comments on this:
 * You are basically duplicating the CheckUser interface. This is bad because
 changes in one part of the CheckUser code will not affect other parts. Code
 duplication should be avoided when possible.
 * You are constructing raw sql, whereas using the wrapper functions is 
 strongly
 recommended
 * Limits are hardcoded
 * XFF is added as /xff. In the api you will simply want to use a boolean xff
 parameter

Especially with a high sensitivity module such as CU, I really do want to have
a common backend for the special page and the API module. With all the code
duplication the chances that are high that security vulnerabilities and other
bugs that are found in the API module and fixed are not propagated to the
special page and vice versa. Considering the sensitivity of CheckUser I do not
think that this is acceptable.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

--- Comment #27 from X! soxre...@gmail.com 2011-05-24 10:37:43 UTC ---
The patch is pretty outdated, and I don't even think it works with the current
version. I'm planning on finishing this during the summer, when I finally have
an abundance of time to work on it.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

--- Comment #28 from Brion Vibber br...@wikimedia.org 2011-05-24 17:48:21 UTC 
---
Reverted the commit of the old patch in r88728; please clean it up and remove
code duplication before recommitting.

(The module was disabled already in r88719.)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

--- Comment #20 from Reedy s...@reedyboy.net 2011-05-23 19:46:59 UTC ---
Is this patch/file any use?

What else needs doing?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Attachment #5677|0   |1
is obsolete||

--- Comment #21 from Reedy s...@reedyboy.net 2011-05-23 20:07:08 UTC ---
Created attachment 8572
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8572
Patch updated, stylized

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

--- Comment #22 from Reedy s...@reedyboy.net 2011-05-23 20:07:33 UTC ---
(In reply to comment #20)
 Is this patch/file any use?
 
 What else needs doing?

Looks like it needs a lot of code issues (raw sql) etc fixing up...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Attachment #5169|0   |1
is obsolete||

--- Comment #23 from Reedy s...@reedyboy.net 2011-05-23 21:02:00 UTC ---
Created attachment 8573
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8573
Non raw sql version!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

--- Comment #24 from Reedy s...@reedyboy.net 2011-05-23 23:12:23 UTC ---
Committed the API module in r88704

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Attachment #5169|1   |0
is obsolete||

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Attachment #8572|0   |1
   is patch||
   Attachment #8572|0   |1
is obsolete||
   Attachment #8572|application/octet-stream|text/plain
  mime type||

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2011-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Attachment #8573|0   |1
is obsolete||

--- Comment #25 from Reedy s...@reedyboy.net 2011-05-23 23:14:25 UTC ---
Comment on attachment 8573
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8573
Non raw sql version!

Obsolete as it's supplied

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2010-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

--- Comment #18 from Soxred93 soxre...@gmail.com 2010-07-11 16:59:43 UTC ---
For the curious, I've started work on this again. So far I've got most of the
base functions, all of the classes laid out, and the API is successfully doing
a User - IP check.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2010-06-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Keywords|bugday  |
 Blocks||23855

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2010-01-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Blocks|16633   |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2010-01-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

  Component|CentralAuth |CheckUser
 AssignedTo|vasi...@gmail.com   |soxre...@gmail.com

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15129] CheckUser Api Module

2010-01-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15129

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 CC||agarr...@wikimedia.org,
   ||s...@reedyboy.net
  Component|API |CentralAuth
Version|1.14-svn|any
 AssignedTo|soxre...@gmail.com  |vasi...@gmail.com
Product|MediaWiki   |MediaWiki extensions
Summary|write an API module that|CheckUser Api Module
   |interfaces with Checkuser   |

--- Comment #17 from Reedy s...@reedyboy.net 2010-01-31 00:06:12 UTC ---
Not quite sure this is still under Api, assigning to CentralAuth

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l