[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406 Brion Vibber changed: What|Removed |Added Keywords||need-unittest Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #25 from Brion Vibber 2011-06-22 20:02:19 UTC --- r86088 is seriously broken and may get reverted; reopening. Needs unit tests (see initial basic unit tests in r90595 which show up errors; will also need tests for the particular case this bug is about.) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406 DieBuche changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #24 from DieBuche 2011-04-15 08:36:31 UTC --- r86088 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406 --- Comment #23 from SharkD 2011-01-12 19:36:29 UTC --- Quote: "How come this has stalled for so long?" Because I got into an argument with the devs and they said they would no longer be looking at my requests. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406 --- Comment #22 from DieBuche 2011-01-08 15:18:27 UTC --- fixed in patch for Bug 8028 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406 DieBuche changed: What|Removed |Added CC||diebu...@gmail.com AssignedTo|wikibug...@lists.wikimedia. |diebu...@gmail.com |org | --- Comment #21 from DieBuche 2010-12-20 00:08:42 UTC --- will be fixed in the jQuery implementation -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406 Michael Walsh changed: What|Removed |Added CC||michaelj.wa...@oceanfree.net --- Comment #20 from Michael Walsh 2009-12-23 20:22:33 UTC --- How come this has stalled for so long? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406
--- Comment #19 from SharkD 2009-01-26 21:18:09 UTC ---
(In reply to comment #17)
> Then should the regex have the spaces, too? i.e.
> var sortClass = (' ' + td.className + ' ').match(/ (sort\-\w+) /);
> It seems like that should avoid false positives in the match.
I suppose it can't hurt. I don't think false positives are very likely though.
-Mike
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406 dpotter changed: What|Removed |Added CC||fa12...@primus.ca --- Comment #18 from dpotter 2009-01-24 15:43:21 UTC --- *** Bug 13535 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406
--- Comment #17 from Steve Sanbeg 2009-01-23 20:52:13 UTC ---
(In reply to comment #16)
> (In reply to comment #15)
> > (In reply to comment #14)
> > > Should the regex be anchored? I think something like
> > > var sortClass = ('' + td.className + '').match(/^sort-\w+$/);
> > >
> > > would be more appropriate
> > >
> > Oops, that would probably break multiple classes
>
> You just made me notice that the quotes are supposed to have spaces in them.
> I.e.
>
> - var sortClass = ('' + td.className + '').match(/(sort\-\w+)/);
> + var sortClass = (' ' + td.className + ' ').match(/(sort\-\w+)/);
>
> -Mike
>
Then should the regex have the spaces, too? i.e.
var sortClass = (' ' + td.className + ' ').match(/ (sort\-\w+) /);
It seems like that should avoid false positives in the match.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406
--- Comment #16 from SharkD 2009-01-22 10:43:41 UTC ---
(In reply to comment #15)
> (In reply to comment #14)
> > Should the regex be anchored? I think something like
> > var sortClass = ('' + td.className + '').match(/^sort-\w+$/);
> >
> > would be more appropriate
> >
> Oops, that would probably break multiple classes
You just made me notice that the quotes are supposed to have spaces in them.
I.e.
- var sortClass = ('' + td.className + '').match(/(sort\-\w+)/);
+ var sortClass = (' ' + td.className + ' ').match(/(sort\-\w+)/);
-Mike
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406
--- Comment #15 from Steve Sanbeg 2009-01-21 19:23:03 UTC ---
(In reply to comment #14)
> Should the regex be anchored? I think something like
> var sortClass = ('' + td.className + '').match(/^sort-\w+$/);
>
> would be more appropriate
>
Oops, that would probably break multiple classes
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15406] Wikibits patch #9 - force sortorder of a column
https://bugzilla.wikimedia.org/show_bug.cgi?id=15406
Steve Sanbeg changed:
What|Removed |Added
CC||ssan...@web.de
--- Comment #14 from Steve Sanbeg 2009-01-21 19:21:52 UTC ---
Should the regex be anchored? I think something like
var sortClass = ('' + td.className + '').match(/^sort-\w+$/);
would be more appropriate
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
