[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=65984 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 --- Comment #13 from kunalgrove...@gmail.com --- Submitted a patch successfully here https://gerrit.wikimedia.org/r/#/c/107837/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 107837 had a related patch set uploaded by 01tonythomas: Patch to remove success box on changing any preference or switching tab https://gerrit.wikimedia.org/r/107837 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 --- Comment #15 from Tony Thomas 01tonytho...@gmail.com --- (In reply to comment #12) Created attachment 14325 [details] Patch to remove success box on changing any preference or switching tab You should go through www.mediawiki.org/wiki/Gerrit/Tutorial next time to submit a patch using git-review. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 --- Comment #16 from kunalgrove...@gmail.com --- Thank you Tony. I was unable to submit a patch because my proxy doesn't allow SSH to Gerrit port. I will try and submit it through git-review next time by some other internet connection. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 --- Comment #17 from kunalgrove...@gmail.com --- Thank you Tony. I was unable to submit a patch because my proxy doesn't allow SSH to Gerrit port. I will try and submit it through git-review next time by some other internet connection. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 kunalgrove...@gmail.com changed: What|Removed |Added CC||kunalgrove...@gmail.com --- Comment #10 from kunalgrove...@gmail.com --- Hi I am new here and wanted to work on this bug. I implemented it as this-Whenever a user changes the preferences tab or reloads or clicks on any section of the preferences tabs, the message is hidden. Is it a good implementation? I liked Jared's idea as well. Can anyone suggest how I should implement it? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 --- Comment #11 from Tony Thomas 01tonytho...@gmail.com --- (In reply to comment #10) Hi I am new here and wanted to work on this bug. I implemented it as this-Whenever a user changes the preferences tab or reloads Great. I will assign the same to you. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added Assignee|01tonytho...@gmail.com |kunalgrove...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 --- Comment #12 from kunalgrove...@gmail.com --- Created attachment 14325 -- https://bugzilla.wikimedia.org/attachment.cgi?id=14325action=edit Patch to remove success box on changing any preference or switching tab I was unable to submit the patch to gerrit directly because of ISP issues. As suggested by sumanah on IRC, I tried to submit it using the online gerrit uploader but it gave me an error as well. So I posted the patch here directly. Can someone please review it and tell if I should modify it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added Summary|JS: Automatically hide |JS: Automatically hide |changes saved message |Your preferences have been |when changing preferences |saved. message when ||changing preferences -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17496] JS: Automatically hide Your preferences have been saved. message when changing preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 --- Comment #9 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org --- If we're going to show and hide this after a timer if prefer it was a floating fixed element rather than an in-line one, A. So the user sees it, and B. So it isn't making the content of the page refactor when it appears and disappears. If reccomend 4 seconds for the time on screen. To address the issue of knowing if it saved I'd recommend disabling the save button if no changes have been made since last save. I don't think this is absolute needed but it's another reminder that there is nothing you need to do. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
