[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2011-08-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765

Dan Collins en.wp.s...@gmail.com changed:

   What|Removed |Added

   Keywords||parsertest
 CC||en.wp.s...@gmail.com

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2011-04-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Keywords|parser, triage  |newparser
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2011-04-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765

Mark Clements (HappyDog) w...@kennel17.co.uk changed:

   What|Removed |Added

   Keywords||triage

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2010-01-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765





--- Comment #10 from Platonides platoni...@gmail.com  2010-01-14 16:20:25 UTC 
---
(In reply to comment #8)
 Fix the heuristic for the case with six quotes.
 Added another parsetest for that.

Committed in r61052


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-09-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765


Platonides platoni...@gmail.com changed:

   What|Removed |Added

Attachment #6589 is|0   |1
   obsolete||




--- Comment #8 from Platonides platoni...@gmail.com  2009-09-28 14:09:12 UTC 
---
Created an attachment (id=6595)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6595)
Parser change

Fix the heuristic for the case with six quotes.
Added another parsetest for that.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-09-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765


Platonides platoni...@gmail.com changed:

   What|Removed |Added

   Keywords||parser




-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-09-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765





--- Comment #9 from Platonides platoni...@gmail.com  2009-09-28 14:58:40 UTC 
---
Created an attachment (id=6596)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6596)
Full grabbing in regex

Accumulative patch to move the quote grabbing logic from php code to the regex.
It doesn't change the parser behavior, just the implementation.

The regex is faster than the php code, but the most fastened path is an
uncommon one, and the regex is more complex. Needs benchmarking.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-09-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765





--- Comment #7 from Platonides platoni...@gmail.com  2009-09-27 21:16:45 UTC 
---
Created an attachment (id=6589)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6589)
Parser change

MediaWiki handles unbalanced quotes by looking at the different words length
and doing a guess.

The test case showed several issues:
-MediaWiki treated the beginning of line as a multiletter word.
-Markup as span or | are treated as words.

There's also the parser assumption that words are separated by spaces, which is
not true for all languages.

The patch fixes just the first issue (plus parsertest and releasenotes).

Many usages now work, but 
span'''Look at ''this edit'''s complicated bold/italic markup!'''/span 
and
{|
|'''Look at ''this edit'''s complicated bold/italic markup!'''
|}

Still fail, since it thinks span and | is text instead of markup. I don't
think it's worth trying to instruct it that.


The behavior of parsertest Mixing markup for italics and bold changed, since
it began the line with bold quotes.
I modified the rule If there are more than 5 apostrophes in a row, assume
they're all text except for the last 5. rule to make the 6 apostrophes produce
the original bbold/bbboldibolditalics/i/b. It still spits single
quotes to match open italic and bold but general behavior seems closer to what
a human would expect. See the new 'Six quotes' parsertest for all the cases.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-09-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765


Platonides platoni...@gmail.com changed:

   What|Removed |Added

   Keywords|need-parsertest |need-review




-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-09-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765


Platonides platoni...@gmail.com changed:

   What|Removed |Added

 CC||platoni...@gmail.com




--- Comment #5 from Platonides platoni...@gmail.com  2009-09-25 12:32:01 UTC 
---
It has worked this way since MediaWiki 1.3

MediaWiki 1.2 produce the same html for both cases, but in a third way:
strongLook at emthis edit/em/strongems complicated bold/italic
markup!/em


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-09-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765





--- Comment #6 from Mark Clements (HappyDog) w...@kennel17.co.uk  2009-09-25 
13:41:10 UTC ---
OK - just a bit of faulty wiring then... damn this broken brain of mine! :-)


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-05-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765


Brion Vibber br...@wikimedia.org changed:

   What|Removed |Added

   Keywords||need-parsertest




--- Comment #3 from Brion Vibber br...@wikimedia.org  2009-05-14 23:48:43 UTC 
---
Whitespace may affect things in order to ensure proper handling of the 's and
l' sort of cases... but start-of-line and whitespace probably should look the
same there.

Needs to be checked against the other test cases...


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-05-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765





--- Comment #4 from Mark Clements (HappyDog) w...@kennel17.co.uk  2009-05-15 
00:18:19 UTC ---
Interestingly, I thought the parser used to format this kind of example in the
manner described for when there is white-space at the the start, rather than
the example without, however it now seems to use the non-white-space formatting
as standard, with the white-space version only appearing in the described edge
case.  This is what I was eluding to in the last para of my original post.  

Is there a possibility that this behaviour has changed in a parser update
(which could have some serious implications), or is my memory just faulty?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 18765] Bold/italic markup handled differently depending on leading whitespace

2009-05-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=18765


Steve Sanbeg ssan...@web.de changed:

   What|Removed |Added

 CC||ssan...@web.de
Summary|Bold/italic markup handled  |Bold/italic markup handled
   |differently in tables.  |differently depending on
   ||leading whitespace




--- Comment #2 from Steve Sanbeg ssan...@web.de  2009-05-12 18:52:32 UTC ---
bold/italic has a fairly complex heuristic to determine how they match.  It's
not dependent on tables, but it is (apparently) sensitive to whitespace.  Your
test-case shows the difference one extra space in the line can make.  I don't
think the table is relevant, other than how it causes the whitespace to render.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l