[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 duplicate...@googlemail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||duplicate...@googlemail.com Resolution||FIXED --- Comment #18 from duplicate...@googlemail.com 2012-10-02 18:15:04 UTC --- fixed with r79398 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||need-review CC||suma...@panix.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com --- Comment #15 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 2011-02-10 05:07:47 UTC --- 1.18 supports $sk-setRelevantTitle( ... ); now and is used in Special:Movepage so that the tabs stay the same. SkinTemplate was also tweaked so that the movepage tab will be selected like the other tabs are. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #14 from Roan Kattouw roan.katt...@gmail.com 2009-05-15 10:49:22 UTC --- (In reply to comment #11) (In reply to comment #7) What if there was a special way to register a special page as an action. class ActionPage extends SpecialPage { /* stuff here that makes the special page behave like an action */ } Then we moved all existing actions into ActionPage classes... Yuck. Why? We've already got a perfectly good way to register actions. Yes, but the handlers for these actions are often in the 'wrong' classes (mostly Article), resulting in poor DB/UI separation. Of course putting the UI for an action in its own class is no guarantee for proper separation, as evidenced by the way subpage moving was implemented. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 --- Comment #5 from Brion Vibber br...@wikimedia.org 2009-05-14 20:44:17 UTC --- More special pages would be a big step backwards since it would make the UI even more broken. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 --- Comment #6 from Happy-melon happy-me...@live.com 2009-05-14 20:57:06 UTC --- What do you mean? Is it broken in more ways than just having the wrong tabs? It seems to me that things like permissions, robot policies, caching, etc, can be more cleanly set in a special page system than in the action= system. The UI is broken, IMO, due to its inconsistency, not because of the use of special pages per se. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 --- Comment #7 from Trevor Parscal tpars...@wikimedia.org 2009-05-14 20:59:32 UTC --- What if there was a special way to register a special page as an action. class ActionPage extends SpecialPage { /* stuff here that makes the special page behave like an action */ } Then we moved all existing actions into ActionPage classes... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 --- Comment #8 from Aryeh Gregor simetrical+wikib...@gmail.com 2009-05-14 21:19:22 UTC --- That's what I was thinking, yes. But that would probably require a lot of refactoring if we wanted to avoid code duplication. Making MovePage an action would admittedly be simpler, most likely. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 --- Comment #9 from Happy-melon happy-me...@live.com 2009-05-14 21:28:25 UTC --- I'm just looking at playing with SkinTemplate.php to allow a second Title object to be specified, the Title of the page to render most of the UI for. Tabs are working fine now; just the sidebar. It's probably not as clean as it could be *within* SkinTemplate.php, but the external interface is fairly nice - just a new $wgUser-getSkin-setTitleForTabs( $titleObj ) function to call from any required special page. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 --- Comment #10 from Trevor Parscal tpars...@wikimedia.org 2009-05-14 21:30:29 UTC --- Just because we add the ActionPage class and it's functionality with the UI doesn't mean we have to migrate all actions immediately. They can migrate over time... SkinTemplate is what's generating the list of actions for monobook (and other SkinTemplate based skins) - so the extra code to grab actions registered from ActionPage classes would go there. As we move actions into ActionPage classes, we just update that function accordingly until everything is migrated. This will also make for a much better way to make page actions in the future. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 --- Comment #11 from Brion Vibber br...@wikimedia.org 2009-05-14 21:33:58 UTC --- (In reply to comment #7) What if there was a special way to register a special page as an action. class ActionPage extends SpecialPage { /* stuff here that makes the special page behave like an action */ } Then we moved all existing actions into ActionPage classes... Yuck. Why? We've already got a perfectly good way to register actions. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 --- Comment #12 from Happy-melon happy-me...@live.com 2009-05-14 21:44:45 UTC --- Created an attachment (id=6118) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6118) Allows special pages to use the UI of other pages Try this; it tweaks Special:MovePage to display all the paraphenalia of the page that's being moved. The tabs work, and work very nicely; the sidebar currently doesn't: the WhatLinksHere, RecentChanges and Permalink links *are* processed by SkinTemplate::buildNavUrls(), but are then removed somewhere downstream; I'm not sure where. Thoughts? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 Happy-melon happy-me...@live.com changed: What|Removed |Added Attachment #6118 is|0 |1 obsolete|| --- Comment #13 from Happy-melon happy-me...@live.com 2009-05-14 21:53:30 UTC --- Created an attachment (id=6119) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6119) Fix the missing links Found it; it was being eaten by the Monobook output template. Yet another area where there's unhealthy amounts of obfuscation and duplication. But meh. What do people think of this method? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18789] Page move should have more similar UI to delete, edit, etc. (keep tabs at top and highlight appropriate one, ...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=18789 Aryeh Gregor simetrical+wikib...@gmail.com changed: What|Removed |Added Summary|'Move' tab should be|Page move should have more |implemented as action=move |similar UI to delete, edit, |instead of Special:MovePage |etc. (keep tabs at top and ||highlight appropriate one, ||...) --- Comment #4 from Aryeh Gregor simetrical+wikib...@gmail.com 2009-05-13 22:46:47 UTC --- Oh, I see. I wasn't getting that. I've adjusted the summary to be more suitable: the point is that you want stuff like keeping the same tabs on the top (instead of becoming just special page). This is a UI issue, not implementation. There are probably a lot of ways in which it differs . . . all the toolbox links and whatnot. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l