https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Mark A. Hershberger m...@everybody.org changed:
What|Removed |Added
Priority|High|Highest
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #48 from Bawolff bawolff...@gmail.com 2011-03-17 15:37:30 UTC ---
The other thing I wanted to mention is the order parameter (order ascending or
descending). Do we really need that. Is there any valid use case for wanting an
rss
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #47 from Bawolff bawolff...@gmail.com 2011-03-17 04:51:39 UTC ---
I poked at this last weekend, and a little bit this week.
I think most of the issues brought up in previous reviews have been addressed,
and that this might be ready
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #43 from Jason Giglio g...@gigstaggart.com 2011-03-09 16:37:18
UTC ---
The code style issues raised before should be addressed now. SQL is
parameterized, and the output is using an XML library.
The only remaining problem is that
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #44 from Reedy s...@reedyboy.net 2011-03-09 17:01:31 UTC ---
It's annoying. Though, if it's not an easy task to strip out the duplication,
IMHO, it's not really blocker for deployment, as long as the code is up to
standard
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #45 from Reedy s...@reedyboy.net 2011-03-09 17:15:13 UTC ---
Though, the echo's need tidying up...
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #46 from Jason Giglio g...@gigstaggart.com 2011-03-09 19:18:47
UTC ---
I don't think we ever want to output the full skinned html here.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #42 from Amgine amgine.sae...@gmail.com 2011-03-09 05:48:39 UTC
---
There is a renewed need for this functionality on en.WN. Is there any way WMF
devs could take a look at this bug?
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #41 from Mark A. Hershberger m...@everybody.org 2011-02-11
22:22:47 UTC ---
Jason:
Sorry I didn't see your update earlier. The most recent changes I see are from
you about a month ago (2010-12-31). Let me know if those are your
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #40 from Jason Giglio g...@gigstaggart.com 2011-02-01 22:34:40
UTC ---
So at this point, most of the major code style problems have been addressed.
There's still a lot of overlap between this and DPL though. I don't really
have a
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #37 from Reedy s...@reedyboy.net 2010-11-29 08:35:43 UTC ---
For an easy changelog, please see
http://www.mediawiki.org/w/index.php?path=/trunk/extensions/GoogleNewsSitemaptitle=Special:Code/MediaWiki/path
There hasn't been much
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #38 from Jason Giglio g...@gigstaggart.com 2010-11-29 15:02:45
UTC ---
I think the easiest thing would be to check my copy in losing Reedy's changes.
Mine seems to be further along, and it should include all the whitespace
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #39 from Reedy s...@reedyboy.net 2010-11-29 15:30:08 UTC ---
Feel free to put it over the top
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #36 from Jason Giglio g...@gigstaggart.com 2010-11-29 05:12:58
UTC ---
I know I merged two of the files. The renaming, I don't remember if I did it
or if it's happened in SVN since my development started.
As far as my changes,
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #33 from Kim Bruning k...@bruning.xs4all.nl 2010-11-25 01:27:56
UTC ---
(In reply to comment #32)
Kim, Could you commit that code?
Sure. One small snag.
Going through the steps to commit,
While attempting to merge and compare
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Reedy s...@reedyboy.net changed:
What|Removed |Added
CC||s...@reedyboy.net
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #35 from Kim Bruning k...@bruning.xs4all.nl 2010-11-25 01:43:31
UTC ---
Ok, there's some pretty major discrepancies. All the files have been renamed,
for starters. I'm going to have to take a better look this coming week. ^^;;
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #32 from Mark A. Hershberger m...@everybody.org 2010-11-23
18:33:33 UTC ---
Kim, Could you commit that code?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #31 from Kim Bruning k...@bruning.xs4all.nl 2010-11-15 04:53:19
UTC ---
And I have now found the partially refactored version.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #30 from Jason Giglio g...@gigstaggart.com 2010-11-12 19:03:42
UTC ---
Thanks Mark. That will be helpful.
As an update, Kim and I are trying to find my partially refactored version.
I'm sure we have a copy somewhere. :)
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #28 from Mark A. Hershberger m...@everybody.org 2010-11-12
03:22:36 UTC ---
Copying this from my notes, will put on CR if it doesn't format here.
* From RK:
** Detection for FlaggedRevs presence is fragile and I'm not sure it'll
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #29 from Mark A. Hershberger m...@everybody.org 2010-11-12
03:45:15 UTC ---
See r76544 for a easier to read review.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #27 from Mark A. Hershberger m...@everybody.org 2010-11-09
18:49:09 UTC ---
Kim, Jason,
I'm contacting you via email to see if we can work with you to get this fixed
up and deployed.
Mark.
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #26 from Kim Bruning k...@bruning.xs4all.nl 2010-11-07 00:43:10
UTC ---
(In reply to comment #25)
I will try to find some time to look at it again. I had a version that was
partially rewritten.
Cool, Can you show me?
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Rob Lanphier ro...@wikimedia.org changed:
What|Removed |Added
CC||m...@everybody.org,
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #20 from Amgine amgine.sae...@gmail.com 2010-10-26 18:25:00 UTC
---
Let me see, written by volunteers, begged for feedback for months, rewritten by
staff, left on hold for review for 10 months...
What do you want, Rob Lanphier?
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #21 from Rob Lanphier ro...@wikimedia.org 2010-10-26 18:44:14 UTC
---
Amgine, this extension only came to my attention this weekend. I think you'll
do best by asking nicely for help on wikitech-l.
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #22 from Amgine amgine.sae...@gmail.com 2010-10-26 18:54:32 UTC
---
No thanks. I've washed my hands of it.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Kim Bruning k...@bruning.xs4all.nl changed:
What|Removed |Added
Priority|Normal |High
--- Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #24 from Rob Lanphier ro...@wikimedia.org 2010-10-26 19:45:41 UTC
---
Hi Kim, this is being discussed on IRC on #mediawiki:
http://toolserver.org/~mwbot/logs/%23mediawiki/20101026.txt
Roan had a few concerns (see log) that would
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #25 from Jason Giglio g...@gigstaggart.com 2010-10-26 21:06:19
UTC ---
I will try to find some time to look at it again. I had a version that was
partially rewritten.
I concur with Roan's observations about the code quality.
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Priyanka Dhanda pdha...@wikimedia.org changed:
What|Removed |Added
AssignedTo|pdha...@wikimedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Amgine amgine.sae...@gmail.com changed:
What|Removed |Added
Keywords||bugsmash
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #17 from Amgine amgine.sae...@gmail.com 2010-02-09 20:08:02 UTC
---
(In reply to comment #16)
What's current status on this? Has activity died down again?
Told you so.
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #13 from Priyanka Dhanda pdha...@wikimedia.org 2009-12-30
22:29:54 UTC ---
Brian, Jason,
I did a little cleanup. Let me know when you have verified it and whether you
are satisfied with it now.
-p
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #14 from Brian McNeil brian.mcn...@wikinewsie.org 2009-12-31
01:23:45 UTC ---
Priyanka,
I'm looking at the changes you checked in (I'm a noob to php)
#par is used by dpl_param on line 305 thus:
$feedType =
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #15 from Jason Giglio g...@gigstaggart.com 2009-12-31 03:17:17
UTC ---
I don't have access to svn right now, (on vacation), but I have already done
most of the changes to migrate to wgRequest and get away from par entirely..
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #8 from Brian McNeil brian.mcn...@wikinewsie.org 2009-12-23
11:47:48 UTC ---
I'm going to ask Josh at Google if there's someone from there can take a look
at this. We're effectively developing a general-purpose addon which a
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #9 from Roan Kattouw roan.katt...@gmail.com 2009-12-23 13:14:21
UTC ---
(In reply to comment #6)
Amgine,
I noticed that the parameters work as part of the url
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #10 from Priyanka Dhanda pdha...@wikimedia.org 2009-12-23
19:50:38 UTC ---
Bawolff, makes sense.
The fix for the request params is pretty simple, I can make it if we don't hear
back from Amgine soon.
Thanks for the feedback
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #11 from Jason Giglio g...@gigstaggart.com 2009-12-23 19:54:21
UTC ---
I was planning on doing that as the first stage in cleaning it up.
I've got the test environment going and plan to take a look at it tonight.
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #12 from Amgine amgine.sae...@gmail.com 2009-12-23 22:06:41 UTC
---
Sorry for the delays: I'm road tripping into a winter storm here, but I should
have internet access fairly regularly for the next two days (or longer if we
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #4 from Kim Bruning k...@bruning.xs4all.nl 2009-12-22 13:20:43
UTC ---
I've created a vm with the latest versions of mediawiki and gnsm from svn
( http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/GNSM )
Please send
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Priyanka Dhanda pdha...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Roan Kattouw roan.katt...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #6 from Priyanka Dhanda pdha...@wikimedia.org 2009-12-23
00:52:55 UTC ---
Amgine,
I noticed that the parameters work as part of the url
http://wiki.enwn.net/index.php/Special:Google_News_SiteMap/feed=rssorder=descending
but
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #7 from Bawolff bawolff...@gmail.com 2009-12-23 04:15:21 UTC ---
Note, Amgine is currently on a road trip, and might have limited internet
connectivity, and might take longer to respond. (however that might have just
been for
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
Reedy s...@reedyboy.net changed:
What|Removed |Added
Component|General/Unknown |General/Unknown
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #1 from Bawolff bawolff...@gmail.com 2009-12-21 22:37:51 UTC ---
Created an attachment (id=6899)
-- (https://bugzilla.wikimedia.org/attachment.cgi?id=6899)
diff to add support for mapping between category schemas.
I've added
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
p858snake p858sn...@yahoo.com.au changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #2 from Jon Davis w...@konsoletek.com 2009-12-21 23:25:48 UTC ---
Someone munged the FR translations in SpecialGNSM.i18n.php . Among the bad
characters in almost every line, specifically 'gnsm_noincludecats' contains an
extra
https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #3 from Bawolff bawolff...@gmail.com 2009-12-21 23:37:00 UTC ---
/me notes patch above that fixes apostraphe issue :P
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving
52 matches
Mail list logo
