[Bug 22227] SpecialListfiles.php throws a fatal error when a spooky file File: exists (for one reason or another)

2011-06-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7

Chad H.  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #7 from Chad H.  2011-06-07 18:52:54 UTC 
---
Used makeTitleSafe, r89674.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22227] SpecialListfiles.php throws a fatal error when a spooky file File: exists (for one reason or another)

2011-06-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7

Brion Vibber  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #6 from Brion Vibber  2011-06-07 18:46:22 UTC 
---
Fix in r87347 doesn't look right; it's checking the return value of
Title::makeTitle for truthiness, but Title::makeTitle doesn't validate and
never returns something that evaluates to false.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22227] SpecialListfiles.php throws a fatal error when a spooky file File: exists (for one reason or another)

2011-05-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7

Chad H.  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22227] SpecialListfiles.php throws a fatal error when a spooky file File: exists (for one reason or another)

2011-05-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7

--- Comment #5 from Chad H.  2011-05-03 19:49:39 UTC 
---
Fixed in r87347 for Special:ListFiles.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22227] SpecialListfiles.php throws a fatal error when a spooky file File: exists (for one reason or another)

2010-01-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7

T. Gries  changed:

   What|Removed |Added

Summary|SpecialListfiles.php throws |SpecialListfiles.php throws
   |a fatal abort when a spooky |a fatal error when a spooky
   |file File: exists (for one  |file File: exists (for one
   |reason or another)  |reason or another)

--- Comment #4 from T. Gries  2010-01-22 19:02:31 UTC ---
(In reply to comment #3)
> (In reply to comment #1)
> > wfLocalFile is supposed to "Return a valid placeholder object if the file 
> > does
> > not exist." :/
> > Something is going wrong inside the LocalRepo.
> 
> Except it lies. If it's not fed a valid title (in this case, an empty string),
> it will return null before trying to construct a file object. See
> FileRepo::newFile()

Okay, and all callers receiving the null "object" shall not throw a fatal error

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l