https://bugzilla.wikimedia.org/show_bug.cgi?id=22904
Summary: [PATCH] don't unnecessarily override "a.external"
links "background-color:" CSS property
Product: MediaWiki
Version: 1.17-svn
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: Normal
Component: General/Unknown
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: ms...@freezone.co.uk
http://www.sfu.ca/~jdbates/tmp/mediawiki/201003190/patch
By using the "background:" shorthand CSS property to specify the external.png
graphic next to "#bodyContent a.external" links, skins/monobook/main.css
unnecessarily overrides the "background-color:" property
This makes customizing MediaWiki with additional CSS a little tedious - for
example I added to our custom CSS,
a:focus,
a:hover
{
background: #ffc;
}
All links now have a yellow background when hovered over - except "#bodyContent
a.external" links
I could amend our custom CSS, specifically mentioning "a.external",
a:focus,
a:hover,
#bodyContent a.external:focus,
#bodyContent a.external:hover
{
background-color: #ffc;
}
However if the skins/monobook/main.css "#bodyContent a.external" rule set
properties more carefully, this wouldn't be necessary,
#bodyContent a.external
{
background-image: url(external.png);
background-position: right;
background-repeat: no-repeat;
}
^ this achieves the same "a.external" link style as the "background:" shorthand
property, without unnecessarily overriding the "background-color:" property
This avoids making "a.external" links unnecessarily inconsistent with other
links
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
