[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Keywords|easy| CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 --- Comment #14 from Chad H. innocentkil...@gmail.com 2011-07-06 22:02:09 UTC --- As of r91609: $ php maintenance/checkSyntax.php Building file list...done. Checking syntax (using php -l, this can take a long time) Warning in file /www/phase3/includes/filerepo/ForeignAPIFile.php: Error supression operator (@) found. Warning in file /www/phase3/includes/json/Services_JSON.php: Error supression operator (@) found. Warning in file /www/phase3/includes/libs/jsminplus.php: trailing ? found. Warning in file /www/phase3/includes/media/Exif.php: Error supression operator (@) found. Warning in file /www/phase3/includes/parser/Parser.php: Error supression operator (@) found. Warning in file /www/phase3/includes/parser/Parser_LinkHooks.php: Error supression operator (@) found. Warning in file /www/phase3/includes/profiler/Profiler.php: Error supression operator (@) found. Warning in file /www/phase3/includes/Revision.php: Error supression operator (@) found. Warning in file /www/phase3/includes/Sanitizer.php: Error supression operator (@) found. Warning in file /www/phase3/includes/search/SearchMySQL.php: Error supression operator (@) found. Warning in file /www/phase3/includes/search/SearchSqlite.php: Error supression operator (@) found. Warning in file /www/phase3/includes/Setup.php: Error supression operator (@) found. Warning in file /www/phase3/includes/specials/SpecialWantedpages.php: Error supression operator (@) found. Warning in file /www/phase3/includes/StreamFile.php: Error supression operator (@) found. Warning in file /www/phase3/includes/User.php: Error supression operator (@) found. Warning in file /www/phase3/maintenance/backup.inc: Error supression operator (@) found. Warning in file /www/phase3/maintenance/checkImages.php: Error supression operator (@) found. Warning in file /www/phase3/maintenance/importImages.php: Error supression operator (@) found. Warning in file /www/phase3/maintenance/importUseModWiki.php: Error supression operator (@) found. Warning in file /www/phase3/maintenance/language/StatOutputs.php: Error supression operator (@) found. Warning in file /www/phase3/maintenance/Maintenance.php: Error supression operator (@) found. Warning in file /www/phase3/maintenance/proxy_check.php: Error supression operator (@) found. Warning in file /www/phase3/maintenance/storage/fixBug20757.php: Error supression operator (@) found. Warning in file /www/phase3/maintenance/userOptions.inc: Error supression operator (@) found. Done! 1134 files checked, 0 failures and 24 warnings found -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 --- Comment #15 from Chad H. innocentkil...@gmail.com 2011-07-06 22:07:46 UTC --- (In reply to comment #14) As of r91609: $ php maintenance/checkSyntax.php Building file list...done. Checking syntax (using php -l, this can take a long time) Warning in file /www/phase3/includes/filerepo/ForeignAPIFile.php: Error supression operator (@) found. Scratch that one, fixed in r91611. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 --- Comment #13 from theto...@ameoto.com 2011-05-16 08:45:11 UTC --- haha, oh wow -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 --- Comment #12 from Chad H. innocentkil...@gmail.com 2011-05-15 14:35:19 UTC --- Using r88187: $ php checkSyntax.php Building file list...done. Checking syntax (using php -l, this can take a long time) Warning in file /opt/local/apache2/htdocs/phase3/includes/api/ApiParse.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/api/ApiQuery.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/api/ApiQueryBacklinks.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/api/ApiQueryExternalLinks.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/cache/MessageCache.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/ConfEditor.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/db/Database.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/db/DatabaseIbm_db2.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/db/DatabaseMysql.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/db/DatabasePostgres.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/diff/DairikiDiff.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/filerepo/ForeignAPIFile.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/filerepo/FSRepo.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/filerepo/LocalFile.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/filerepo/LocalRepo.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/GlobalFunctions.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/HistoryBlob.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/Import.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/json/Services_JSON.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/media/DjVu.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/media/Exif.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/media/SVG.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/objectcache/SqlBagOStuff.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/parser/Parser.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/parser/Parser_LinkHooks.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/profiler/Profiler.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/Revision.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/Sanitizer.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/search/SearchMySQL.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/search/SearchSqlite.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/Setup.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/specials/SpecialLockdb.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/specials/SpecialUnlockdb.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/specials/SpecialWantedpages.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/StreamFile.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/templates/Userlogin.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/includes/User.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/languages/Language.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/maintenance/backup.inc: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/maintenance/checkImages.php: Error supression operator (@) found. Warning in file /opt/local/apache2/htdocs/phase3/maintenance/checkSyntax.php: Error
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 --- Comment #10 from Reedy s...@reedyboy.net 2011-02-10 16:53:49 UTC --- How many more of these are still about? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 --- Comment #11 from Chad H. innocentkil...@gmail.com 2011-02-10 17:04:00 UTC --- Too many :( -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159
theto...@ameoto.com changed:
What|Removed |Added
CC||theto...@ameoto.com
--- Comment #7 from theto...@ameoto.com 2010-10-03 16:29:50 UTC ---
A better solution is to use php's scream flag which overrides the suppression
symbol.
Add a statement to the main construct after the configuration has been loaded
and have it call ini_set('scream.enabled', true); if a debug flag is set,
that way developers can catch all errors regardless of another dev's coding
style.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 Niklas Laxström niklas.laxst...@gmail.com changed: What|Removed |Added CC||niklas.laxst...@gmail.com --- Comment #8 from Niklas Laxström niklas.laxst...@gmail.com 2010-10-03 16:47:28 UTC --- It's an PECL extension which requires PHP 5.2.0. I don't see how that is a solution to this bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 --- Comment #9 from Chad H. innocentkil...@gmail.com 2010-10-03 18:48:07 UTC --- (In reply to comment #8) It's an PECL extension which requires PHP 5.2.0. I don't see how that is a solution to this bug. It's not. We shouldn't be using a PECL extension to get around poor coding. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159
--- Comment #6 from Chad H. innocentkil...@gmail.com 2010-07-02 19:46:24 UTC
---
$ grep -irPn '@[a-z_]+\(' .
This only includes global function calls, which isn't the only place @ can be
used :)
$ grep -irPn '@[a-z_]+::'
Yields 1 static method call. Similar grep for method on object calls came back
negative, yay :)
$ grep -irn '@\$' . | grep -v .svn | grep -v 'Binary file'
Gives you a bunch of variable accessing with @ that I didn't include above :(
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 Reedy s...@reedyboy.net changed: What|Removed |Added CC||s...@reedyboy.net --- Comment #1 from Reedy s...@reedyboy.net 2010-06-29 06:30:09 UTC --- Dump of the what files/lines for the lazy? :P -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159
--- Comment #2 from Chad H. innocentkil...@gmail.com 2010-06-29 12:28:01 UTC
---
Created an attachment (id=7523)
-- (https://bugzilla.wikimedia.org/attachment.cgi?id=7523)
List for the lazy
$ grep -irPn '@[a-z]+\(' . | grep -v .svn | grep -v 'Binary file'
~/uses-...@.txt
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 --- Comment #3 from Chad H. innocentkil...@gmail.com 2010-06-29 12:29:04 UTC --- It has one false positive, an @import in CSS, but it's commented anyway :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Attachment #7523|0 |1 is obsolete|| --- Comment #4 from Chad H. innocentkil...@gmail.com 2010-06-29 12:34:38 UTC --- Created an attachment (id=7524) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7524) Try 2 Forgot to include _ in [a-z]+. This version includes it :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24159] Remove uses of the error suppression operator
https://bugzilla.wikimedia.org/show_bug.cgi?id=24159
--- Comment #5 from Reedy s...@reedyboy.net 2010-06-29 12:42:10 UTC ---
./includes/normal/UtfNormalTest.php:77:if( preg_match( '/@Part([\d])/',
$data, $matches ) ) {
Would be another ;)
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
