[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 Andre Klapper changed: What|Removed |Added Keywords|patch-in-gerrit | Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 --- Comment #8 from Christian Neubauer --- You are wrong sir. The user object in the DB is updated on User.php:3080, then saveOptions() is called on User.php:3098 which in turn fires the UserSaveOptions hook. The email address, password, username, etc are already set and saved by the time the options hook fires. You can modify the user object that is passed into the UserSaveOptions hook but then you will have to save it again yourself manually which doesn't make any sense since it's just been saved by the call to saveSettings(). The old SavePreferences hook used to fire before the user object was saved which allowed you to do things like automatically set a user's email address when you were using a SSO or PKI third party plugin to automatically log your users in. Perhaps there is some way to do this still that I'm overlooking but the UserSaveOptions hook is not it. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 --- Comment #7 from Tyler Romeo --- That's not true at all. UserSaveOptions is fired before the options are saved on User.php:4397. Furthermore, the User object itself is passed as one of the parameters, so you can change the email address if you want as well. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 Christian Neubauer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #6 from Christian Neubauer --- Nope it doesn't. Like I said in the original description, the UserSaveOptions hook is fired after the user object is saved and only allows you to modify user preferences. You can't for example change the user email address before the user object is saved. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 Tyler Romeo changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Tyler Romeo --- The UserSaveOptions hook fulfills this functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 --- Comment #4 from Christian Neubauer 2012-10-09 14:25:57 UTC --- Wooohooo!!! My hero! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 Tyler Romeo changed: What|Removed |Added Keywords||patch-in-gerrit Status|NEW |ASSIGNED CC||tylerro...@gmail.com AssignedTo|wikibugs-l@lists.wikimedia. |tylerro...@gmail.com |org | --- Comment #3 from Tyler Romeo 2012-10-09 03:30:33 UTC --- https://gerrit.wikimedia.org/r/27266 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 Krinkle changed: What|Removed |Added Version|1.16.0 |1.16.x -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 --- Comment #2 from Christian Neubauer 2010-08-26 23:34:15 UTC --- Modifying the user member variables before they are saved to the database. Without a hook, you can't do any sort of validation, modification, etc. Say I want to examine the user's name and auto-update their email address based on that or auto create a signature for the user. Or generate a nickname based on their real name. The only field you can validate right now is the email address which has a dedicated hook. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 --- Comment #1 from Andrew Garrett 2010-08-26 16:46:09 UTC --- What's the use case? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24944] Need hook to allow user object to be modified before it is saved to the database
https://bugzilla.wikimedia.org/show_bug.cgi?id=24944 Christian Neubauer changed: What|Removed |Added Summary|Need hook to all user |Need hook to allow user |object to be modified |object to be modified |before it is saved to the |before it is saved to the |database|database -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
