[Bug 25517] Assignment in conditions should be avoided

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25517

db duplicate...@googlemail.com changed:

   What|Removed |Added

 CC||duplicate...@googlemail.com

--- Comment #6 from db duplicate...@googlemail.com ---
(In reply to comment #5)

Got a ack-grep regex to share?

\(\s*\$[^=\n|');]+[^!=]=\s*\$[^\n)';]+\)

Looks usable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25517] Assignment in conditions should be avoided

2012-10-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25517

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #5 from Krinkle krinklem...@gmail.com 2012-10-26 05:06:44 UTC ---
(In reply to comment #0)
 [..] there are still 56 assignments in conditionals

Got a ack-grep regex to share?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25517] Assignment in conditions should be avoided

2010-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25517

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Depends on||25407

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25517] Assignment in conditions should be avoided

2010-11-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25517

--- Comment #4 from Trevor Parscal tpars...@wikimedia.org 2010-11-01 17:59:07 
UTC ---
Fair enough. I'm fine with avoiding them if we are conforming to an established
standard.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25517] Assignment in conditions should be avoided

2010-10-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25517

--- Comment #3 from Reedy s...@reedyboy.net 2010-10-31 23:52:50 UTC ---
http://www.mediawiki.org/wiki/Manual:Coding_conventions#Assignment_expressions

Turns out it's in the coding conventions...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25517] Assignment in conditions should be avoided

2010-10-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25517

Ashar Voultoiz has...@free.fr changed:

   What|Removed |Added

 CC||has...@free.fr
Summary|Assignment in conditions|Assignment in conditions
   |sucks   |should be avoided

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l