[Bug 25578] We should support XML-valid delimiters for query string parameters

2011-01-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

Brion Vibber br...@pobox.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #9 from Brion Vibber br...@pobox.com 2011-01-02 20:19:31 UTC ---
I'm gonna take the initiative and resolve INVALID (I really want a
'WONTIMPLEMENT' to supplement 'WONTFIX', which implies it's a known problem we
won't fix, rather than a valid, but not desired in this case, option).

Messing with the options to accept semicolons as separators is possible, but
has a bunch of problems:
* would likely break things that submit freeform text in forms, since text can
contain semicolons, so mixed-mode parsing gets confusing
* the settings in php.ini aren't always editable
* even when they are adjustable, PHP code can't change it as it's too late
* it would be possible to reimplement the GET parameter extraction from scratch
in WebRequest, but that doesn't seem worth the effort
* more code paths and more URL variants just sounds icky

The sort of case where this originally came up -- hacky wikitext/HTML/JS
mixture pages that use several layers of processing meant for other layers of
processing to try to whip stuff together -- are good cases for more specialized
systems of template generation that would reduce the need for manual
intervention on the markup level.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25578] We should support XML-valid delimiters for query string parameters

2010-10-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com

--- Comment #6 from Roan Kattouw roan.katt...@gmail.com 2010-10-20 13:11:41 
UTC ---
(In reply to comment #5)
 The URL isn't actually a link in this case. It's a javascript string that gets
 conditionally used as the form action. Obviously we could move this out of
 wikitext, but since these URLs get changed frequently, it's convenient to be
 able to edit it without a code deploy.
 
I'm still not entirely clear on why the URL needs to contain amp; , could you
clarify that?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25578] We should support XML-valid delimiters for query string parameters

2010-10-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

--- Comment #7 from Arthur Richards aricha...@wikimedia.org 2010-10-20 
16:59:54 UTC ---
The URL should NOT contain amp; - rather it needs to have just a '' and NOT
have it escaped (which turns it into 'amp;').

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25578] We should support XML-valid delimiters for query string parameters

2010-10-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

--- Comment #8 from Ryan Kaldari rkald...@wikimedia.org 2010-10-20 17:26:00 
UTC ---
We have solved it by using '\x26' in the wikitext, which gets output as 
rather than amp; in the source. Anyway, the point of this bug was not fixing
the URL, but Do we want to support escaped ampersands in query strings? A lot
of web applications do, a lot don't. If we don't, I'll close the bug. If we do,
I'll check in the code above.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25578] We should support XML-valid delimiters for query string parameters

2010-10-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

--- Comment #1 from Arthur Richards aricha...@wikimedia.org 2010-10-19 
07:59:00 UTC ---
As a workaround, using the hex values seem to work (at least in Javascript
inside of wikitext).  eg:
var url = 'http://foo.com/index.php?bar=bazbanana=sandwich';

can be written as:
var url = 'http://foo.com/index.php?bar=baz\x26banana=sandwich';

But still, the user-friendly solution would be to find a way to allow users to
explicitly use '' in query strings written in wikitext.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25578] We should support XML-valid delimiters for query string parameters

2010-10-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

Niklas Laxström niklas.laxst...@gmail.com changed:

   What|Removed |Added

 CC||niklas.laxst...@gmail.com

--- Comment #2 from Niklas Laxström niklas.laxst...@gmail.com 2010-10-19 
08:48:52 UTC ---
I don't understand what the problem is here. Can you give examples?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25578] We should support XML-valid delimiters for query string parameters

2010-10-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

--- Comment #3 from Arthur Richards aricha...@wikimedia.org 2010-10-19 
17:29:58 UTC ---
(In reply to comment #2)
 I don't understand what the problem is here. Can you give examples?

For instance, on one of the WMF's landing pages for donations, we send users
who wish to make a donation to a credit card form using a URL that has a query
string with the ampersand character in it, something like:
https://payments.wikimedia.org/index.php/Special:PayflowProGateway?uselang=entest=1

Because the landing page is written in a Wiki page, the '' gets escaped to its
htmlentity when the page is rendered, which makes the URL look like:
https://payments.wikimedia.org/index.php/Special:PayflowProGateway?uselang=enamp;test=1

This throws off the processing/interpreting of items in the query string
because suddenly the parameter 'test' gets interpreted as 'amp;test'.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25578] We should support XML-valid delimiters for query string parameters

2010-10-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

--- Comment #4 from Brion Vibber br...@pobox.com 2010-10-19 17:34:19 UTC ---
Sounds like you just gotta fix the link here to make sure you're doing it
correctly. Find and fix the wiki page generating the link?


Changing query string processing to use ; as a separator could open up whole
new exciting cans of worms such as breaking things that try to use, well,
semicolons. :)

I recommend either resolving this bug INVALID or renaming it to A particular
wiki page has a double-escaped link to PayflowProGateway.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25578] We should support XML-valid delimiters for query string parameters

2010-10-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25578

--- Comment #5 from Ryan Kaldari rkald...@wikimedia.org 2010-10-19 18:26:25 
UTC ---
The URL isn't actually a link in this case. It's a javascript string that gets
conditionally used as the form action. Obviously we could move this out of
wikitext, but since these URLs get changed frequently, it's convenient to be
able to edit it without a code deploy.

I agree the semicolon solution is potentially dangerous. Any thoughts on the
2nd proposed solution? Handling escaped ampersands in query strings is pretty
common these days. This site (Wikimedia Bugzilla), for example, handles them
fine, as do most other large websites I've worked for.

Since we have workarounds, I'm fine with WONTFIX or INVALID, but I'm wondering
if there's any downside to the adding the proposed fix.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l