[Bug 25960] Caconical links for File pages of files from a shared repo.

2010-11-17 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=25960

--- Comment #4 from Derk-Jan Hartman  2010-11-17 09:17:31 
UTC ---
I think the check needed for that would be: this->getID() == 0 

I have no real preference either way, what do others think ?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 25960] Caconical links for File pages of files from a shared repo.

2010-11-16 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=25960

Krinkle  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #3 from Krinkle  2010-11-17 01:24:17 UTC ---
Does this also happen when the File-page has a local file page aswell ?

There are many files on Commons that have a mini-page on en.wikipedia with just
a {{FeaturedPicture}} template on it.
MediaWiki handles these local filepages without media as a header for the
shared image description and is displayed between the .sharedUploadNotice and
#shared-image-desc.

Example: http://en.wikipedia.org/wiki/File:NURBS_3-D_surface.gif
This file is on Commons, and description too but it has a local description
aswell

I suggest adding another condition to the if statement added in r76867 to see
if a local page exists, in that case don't create the canonical link.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 25960] Caconical links for File pages of files from a shared repo.

2010-11-16 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=25960

Derk-Jan Hartman  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||hart...@videolan.org
 Resolution||FIXED

--- Comment #2 from Derk-Jan Hartman  2010-11-17 00:23:42 
UTC ---
Done in r76867

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 25960] Caconical links for File pages of files from a shared repo.

2010-11-16 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=25960

Bawolff  changed:

   What|Removed |Added

 CC||bawolff...@gmail.com

--- Comment #1 from Bawolff  2010-11-16 23:32:35 UTC ---
My first reaction to this was I bet http://googlewebmastercentral.blogspot.com/2009/12/handling-legitimate-cross-domain.html

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l