[Bug 26034] Purge makes the read tab inactive

2012-11-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 CC||matma@gmail.com
 Resolution||WORKSFORME

--- Comment #9 from Bartosz Dziewoński matma@gmail.com 2012-11-17 
18:37:49 UTC ---
(In reply to comment #5)
 Closing again.  If you re-open, make sure to retitle this properly.

It looks like it wasn't closed after all.


But I am closing it now, as WORKSFORME. The purge action now redirects to the
view action, so this is pointless.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26034] Purge makes the read tab inactive

2011-02-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 CC||m...@everybody.org

--- Comment #5 from Mark A. Hershberger m...@everybody.org 2011-02-09 
00:59:26 UTC ---
Closing again.  If you re-open, make sure to retitle this properly.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26034] Purge makes the read tab inactive

2011-02-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #6 from Krinkle krinklem...@gmail.com 2011-02-09 01:09:18 UTC ---
I won't re-open.

(In reply to comment #4)
 purge is not a mode, it's an action - it
 should be an item in the drop down like protect or move.


I agree. For an end-user purge does not belong in the list of: view, edit,
history etc. (modes, views  or p-views)

Although technically purge is as much an action as view, edit, history,
delete etc. is. (atleast when checking the URL and wgAction). But that's behind
the scenes.

In the UI, if a Purge tab is added by whatever script, it should be in the
dropdown (p-actions).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26034] Purge makes the read tab inactive

2011-02-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

--- Comment #7 from Krinkle krinklem...@gmail.com 2011-02-09 01:09:31 UTC ---
p-cactions*

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26034] Purge makes the read tab inactive

2011-01-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||mediawiki-bugs@nadir-seen-f
   ||ire.com
 Resolution||FIXED

--- Comment #1 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 
2011-01-13 22:42:50 UTC ---
Fixed in r80201 for all content_navigation using skins (ie: Vector in 1.18).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26034] Purge makes the read tab inactive

2011-01-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

--- Comment #2 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 
2011-01-13 22:53:21 UTC ---
Backported to 1.17 in r80204.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26034] Purge makes the read tab inactive

2011-01-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #3 from Krinkle krinklem...@gmail.com 2011-01-13 23:03:02 UTC ---
The tabs are for actions.

When viewing the article wgAction= view. When lookig at the history it's
wgAction=history.
When purging the cache the wgAction=purge.

There's many different actions, some by extensions some by core. But I think
going down the path of manually giving 1 action-tab multiple actions is not a
good idea.

See for example the following case: http://i.imgur.com/pWqEn.png
Where there is a Purge-tab. If this makes it into a release you're looking at:

bug: Action=purge wrongly highlights the Read-tab.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26034] Purge makes the read tab inactive

2011-01-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26034] Purge makes the read tab inactive

2011-01-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26034

--- Comment #4 from Trevor Parscal tpars...@wikimedia.org 2011-01-13 23:25:43 
UTC ---
Whatever the chosen action is, despite what is entered in the URL, should be
highlighted. The problem here is that we have logic somewhere saying purge,
ok, I can do that, then logic somewhere else saying purge? never heard of
that, you must mean read! and yet more logic later on saying what action are
we using? I'm gonna highlight something...

What we need to do is ensure that whatever the interpretation of the action
parameter ends up being is reflected in the UI. This is a dirty hack to help
fake that, but it's not setting a dangerous precedence as far as the UI is
concerned.

Also, a purge tab is a bad design - purge is not a mode, it's an action - it
should be an item in the drop down like protect or move.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l