[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #17 from Chad H. innocentkil...@gmail.com 2011-08-05 21:33:37 UTC --- Fixed and re-deployed. See /trunk/tools/subversion/hooks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Keywords||shell -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #16 from Reedy s...@reedyboy.net 2011-07-27 22:32:39 UTC --- This and the empty summary prevention REALLY need fixing :P -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Priority|Normal |High -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #15 from Reedy s...@reedyboy.net 2011-04-02 01:22:31 UTC --- Can we fix plox? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 Reedy s...@reedyboy.net changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #14 from Reedy s...@reedyboy.net 2010-12-22 21:18:36 UTC --- It brokeded -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Chad H. innocentkil...@gmail.com 2010-11-30 14:59:54 UTC --- Done, now checks all .php or .inc or .php5 files changed in a commit for syntax validity. Should output the following on failure: $ svn ci -m 'Try #2' Sendingtest.php Transmitting file data .svn: Commit failed (details follow): svn: Commit blocked by pre-commit hook (exit code 1) with output: PHP Parse error: syntax error, unexpected T_STRING in - on line 1 *** PHP error in: test.php: Errors parsing test.php *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 Reedy s...@reedyboy.net changed: What|Removed |Added CC||s...@reedyboy.net --- Comment #2 from Reedy s...@reedyboy.net 2010-11-30 15:53:54 UTC --- Not that I'm adversed to this, but I thought that we didn't want to do a pre-commit hook as it blocks? And would be especially annoying for large (i18n) etc commits...? Also, what if the file already had it in...? (Granted, if it was tested, they would've found it..) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #3 from Reedy s...@reedyboy.net 2010-11-30 15:54:48 UTC --- https://bugzilla.wikimedia.org/show_bug.cgi?id=20069 is technically redundant now... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 Platonides platoni...@gmail.com changed: What|Removed |Added CC||platoni...@gmail.com --- Comment #4 from Platonides platoni...@gmail.com 2010-11-30 17:53:12 UTC --- Which php version is used? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #5 from Max Semenik maxsem.w...@gmail.com 2010-11-30 17:55:24 UTC --- Can we unleash checkSyntax.php in its fury on files committed? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 Ryan Lane rlan...@gmail.com changed: What|Removed |Added CC||rlan...@gmail.com --- Comment #6 from Ryan Lane rlan...@gmail.com 2010-11-30 17:55:38 UTC --- PHP 5.3.2-1ubuntu4.5 with Suhosin-Patch (cli) (built: Sep 17 2010 13:49:46) Copyright (c) 1997-2009 The PHP Group Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #7 from Chad H. innocentkil...@gmail.com 2010-11-30 17:56:15 UTC --- (In reply to comment #4) Which php version is used? 5.3.2. (In reply to comment #2) Not that I'm adversed to this, but I thought that we didn't want to do a pre-commit hook as it blocks? I don't like the idea of doing extensive pre-commit hooks due to that issue. But php -l is typically very fast. And would be especially annoying for large (i18n) etc commits...? It may be, we're not sure yet. Gonna test it later with Raymond. Also, what if the file already had it in...? (Granted, if it was tested, they would've found it..) Then you fix it too, while you're at it ;-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #8 from Chad H. innocentkil...@gmail.com 2010-11-30 17:57:06 UTC --- (In reply to comment #5) Can we unleash checkSyntax.php in its fury on files committed? checkSyntax.php is slower and checks lots of non-syntax stuff too. That would be better as a post-commit hook. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #9 from Reedy s...@reedyboy.net 2010-11-30 17:57:41 UTC --- Commit your script to SVN? In lint.php.. * Recursive directory crawling PHP syntax checker * Uses parsekit, which is much faster than php -l for lots of files due to the -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #10 from Chad H. innocentkil...@gmail.com 2010-11-30 17:59:36 UTC --- (In reply to comment #9) Commit your script to SVN? I need to clean up the pre/post commit hooks and put them somewhere. Puppet makes more sense than SVN, though. In lint.php.. * Recursive directory crawling PHP syntax checker * Uses parsekit, which is much faster than php -l for lots of files due to the Yes, it's faster, but it's horrendously broken on 5.3.x last I played with it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #11 from Platonides platoni...@gmail.com 2010-11-30 18:00:19 UTC --- (In reply to comment #9) Commit your script to SVN? maintenance/checkSyntax.php ? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #12 from Max Semenik maxsem.w...@gmail.com 2010-11-30 18:03:34 UTC --- (In reply to comment #8) checkSyntax.php is slower and checks lots of non-syntax stuff too. That would be better as a post-commit hook. It isn't much slower on a known list of files. A few regexes is faster than php -l and even parsekit. And some stuff it checks for worth declining on sight, such as common causes of headers already sent errors. Also, it avoids using parsekit on PHP 5.3 where it's broken. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26172] Create pre-commit PHP lint test
https://bugzilla.wikimedia.org/show_bug.cgi?id=26172 --- Comment #13 from Chad H. innocentkil...@gmail.com 2010-11-30 18:05:19 UTC --- (In reply to comment #12) (In reply to comment #8) checkSyntax.php is slower and checks lots of non-syntax stuff too. That would be better as a post-commit hook. It isn't much slower on a known list of files. A few regexes is faster than php -l and even parsekit. And some stuff it checks for worth declining on sight, such as common causes of headers already sent errors. Also, it avoids using parsekit on PHP 5.3 where it's broken. We should rewrite it to not depend on MW at all, then it'll be fast :D -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
