https://bugzilla.wikimedia.org/show_bug.cgi?id=26194
Summary: WikiEditor + Liquidthreads: addModules is called once
for each comment, increasing page load times
drastically
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: Normal
Component: UsabilityInitiative
AssignedTo: tpars...@wikimedia.org
ReportedBy: nx.devn...@gmail.com
CC: roan.katt...@gmail.com, amil...@wikimedia.org,
asha...@wikimedia.org
Created attachment 7883
--> https://bugzilla.wikimedia.org/attachment.cgi?id=7883
run addmodules only once
Liquidthreads calls EditPage::getEditToolbar a lot of times (once for each
comment, if I'm not mistaken), each time WikiEditorHooks::addModules runs, and
the result is a huge number of calls to wfMsgReal (over 20000 with a decent
sized lqt talk page), and a drastic increase in page load times. The page will
also contain all the messages multiple times, increasing its size. I've
attached a patch to only run addModules once - I'm not sure this is the correct
way to fix the problem, but addModules shouldn't be adding the same messages
over and over again if it gets called multiple times.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
