[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 Max Semenik maxsem.w...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #9 from Max Semenik maxsem.w...@gmail.com 2011-01-28 08:12:57 UTC --- Never mind, I'm an idiot. It was an Opera extension screwing up things. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 --- Comment #8 from Ryan Kaldari rkald...@wikimedia.org 2011-01-14 23:34:44 UTC --- @Lupo: '[]' is the correct json encoding for an empty array. That shouldn't cause any problems. In fact, '[]' is the value that is normally expected to be returned (when we aren't running banners). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 --- Comment #5 from Ryan Kaldari rkald...@wikimedia.org 2011-01-12 18:11:21 UTC --- Hey Max, were you able to investigate this at work? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381
Lupo lupo.bugzi...@gmail.com changed:
What|Removed |Added
Priority|Normal |High
CC||lupo.bugzi...@gmail.com
--- Comment #6 from Lupo lupo.bugzi...@gmail.com 2011-01-12 21:30:55 UTC ---
JavaScript crash in FF 3.6.4. Observed while visiting the Commons in
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100611
Firefox/3.6.4, may possibly also occur in other browsers.
The crash occurs during $j(document).ready() and prevents later document-ready
handlers from running at all.
FF error console reports:
uncaught exception: [Exception... Component returned failure code: 0x805e000a
[nsIXMLHttpRequest.open] nsresult: 0x805e000a (unknown) location: JS
frame :: http://bits.wikimedia.org/skins-1.5/common/jquery.min.js?283-19 ::
anonymous :: line 383 data: no]
This appears to be caused by the call on lines 54-58 in
http://commons.wikimedia.org/wiki/Special:BannerController
var request = $.ajax( {
url: bannerListURL,
dataType: 'json',
success: $.centralNotice.fn.chooseBanner
} );
The bannerListURL at the time of the call is
http://commons.wikimedia.org/w/index.php?title=Special:BannerListLoadercache=/cn.jslanguage=enproject=commonscountry=
and returns
[]
which is not a JSON object but an empty array. Maybe that's got something to do
with this. Can't verify myself since I cannot step though minified jquery code;
I did get to this $.ajax() call with single-stepping, though.
$.centralNotice.fn.chooseBanner is never called; the exception is therefore
raised earlier inside the $.ajax() call.
The error appears not to depend on the skin, at least it occurs in both
monobook and in vector.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 --- Comment #7 from Max Semenik maxsem.w...@gmail.com 2011-01-13 06:18:10 UTC --- Created attachment 7984 -- https://bugzilla.wikimedia.org/attachment.cgi?id=7984 Dragonfly debug info Here's what I've discovered. Everything seems to be loaded, but jQuery is a roast. Errors look different at different times (at the moment of reporting the BannerController error was first in the list, so I decided that it is to be blamed). Sometimes, there are no errors and JS works, but most of time it's completely screwed up. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 --- Comment #3 from Ryan Kaldari rkald...@wikimedia.org 2011-01-05 18:00:41 UTC --- Tested mediawiki.org and en.wikipedia.org in Opera 11 with CentralNotice banners running, but was not able to reproduce the bug. Max, can you describe the steps to reproduce this bug? Are you still seeing it? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 Ryan Kaldari rkald...@wikimedia.org changed: What|Removed |Added Severity|blocker |critical -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 --- Comment #4 from Max Semenik maxsem.w...@gmail.com 2011-01-05 19:25:44 UTC --- Works for me from home. Probably, something weird with transparent proxy at work. Will investigate this after holidays. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #1 from Roan Kattouw roan.katt...@gmail.com 2010-12-21 11:10:20 UTC --- Works for me in Firefox, and the inclusion order in head looks correct. Opera is known to have issues with loading order, though. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26381] Special:BannerController breaks all JS on live site
https://bugzilla.wikimedia.org/show_bug.cgi?id=26381 --- Comment #2 from Ryan Kaldari rkald...@wikimedia.org 2010-12-21 18:57:46 UTC --- Works for me as well. I suppose I could have CentralNotice make sure that jQuery is defined before it does anything. Any other suggestions? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
