[Bug 26459] The renderNavigation and renderPortals functions should be protected or public instead of private
https://bugzilla.wikimedia.org/show_bug.cgi?id=26459 Mark A. Hershberger changed: What|Removed |Added Status|NEW |RESOLVED CC||m...@everybody.org Resolution||FIXED --- Comment #5 from Mark A. Hershberger 2012-02-10 20:28:37 UTC --- r95 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26459] The renderNavigation and renderPortals functions should be protected or public instead of private
https://bugzilla.wikimedia.org/show_bug.cgi?id=26459 Sumana Harihareswara changed: What|Removed |Added Keywords||need-review, patch CC||suma...@panix.com --- Comment #4 from Sumana Harihareswara 2012-01-19 17:46:07 UTC --- Christian, thanks for the patch. I've added the keywords "need-review" and "patch" so the bug shows up in the lists of patches awaiting review for committing or critique. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26459] The renderNavigation and renderPortals functions should be protected or public instead of private
https://bugzilla.wikimedia.org/show_bug.cgi?id=26459 --- Comment #3 from Christian Neubauer 2012-01-19 13:36:25 UTC --- Created attachment 9867 --> https://bugzilla.wikimedia.org/attachment.cgi?id=9867 Change private functions in Vector.php to protected (In reply to comment #1) > This sort of comment really belongs in CodeReview. See r53210 where I've made > just this comment (prompted by this bug). Thanks, I'll do that next time. If I knew Trevor's email address, I would probably add him to the cc list too so he would see this bug report. That said, the average person submitting a bug is not going to hunt down the annotated code file to determine who first made a change and then hunt down the code review page to comment on it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26459] The renderNavigation and renderPortals functions should be protected or public instead of private
https://bugzilla.wikimedia.org/show_bug.cgi?id=26459 Mark A. Hershberger changed: What|Removed |Added CC||m...@everybody.org --- Comment #1 from Mark A. Hershberger 2011-01-29 01:16:12 UTC --- This sort of comment really belongs in CodeReview. See r53210 where I've made just this comment (prompted by this bug). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
