[Bug 26753] [debug] Class SkinVector not found; skipped loading

2011-01-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26753

Roan Kattouw  changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com
  Component|Vector Skin |General/Unknown
 AssignedTo|tpars...@wikimedia.org  |wikibugs-l@lists.wikimedia.
   ||org

--- Comment #5 from Roan Kattouw  2011-01-21 03:28:35 
UTC ---
Moving to General/Unknown, this problem plagues all skins because none of them
are in the autoloader.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26753] [debug] Class SkinVector not found; skipped loading

2011-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26753

--- Comment #4 from Chad H.  2011-01-17 14:58:23 UTC 
---
That's the exact same conclusion I came to when looking at this last night.
Right now (I believe) the official skin docs say to throw your custom skin in
/skins with all the others. But why should you have to? 

Assuming the skin names are *always* called SkinName with Name being the key,
there's zero reason you can't keep your skin file in /extensions/whatever and
just register in the autoloader.

We should confirm this behavior works.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26753] [debug] Class SkinVector not found; skipped loading

2011-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26753

--- Comment #3 from Bawolff  2011-01-17 14:54:26 UTC ---
I previously said
>Could probably be fixed by passing false as a second parameter to the
>class_exists.

Actually, that'd probably mess things up if a skin type extension tries to use
the autoloader to load an extension skin. I have no idea if any skin extensions
try to do that, but its conceivable they might.

Maybe output a wfDebug line just before doing the check saying to ignore the
next line, but then that is more clutter. Maybe just wontfix?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26753] [debug] Class SkinVector not found; skipped loading

2011-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26753

Chad H.  changed:

   What|Removed |Added

 CC||innocentkil...@gmail.com

--- Comment #2 from Chad H.  2011-01-17 14:13:30 UTC 
---
Not an issue in resource loader or Vector.

This has been cluttering my debug output since time immemorial.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l



[Bug 26753] [debug] Class SkinVector not found; skipped loading

2011-01-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26753

Bawolff  changed:

   What|Removed |Added

 CC||bawolff...@gmail.com
   Severity|major   |minor

--- Comment #1 from Bawolff  2011-01-16 22:26:47 UTC ---
Caused by Skin::newFromKey.

It calls class_exists() on the current skin name, and then requireOnce's the
skin file if the class doesn't exist. class_exists causes the autoloader to try
to load the SkinVector class, which it can't since the skin classes aren't
loaded by the autoloader, but by Skin::newFromKey. Thus the debug message is
harmless, albeit a bit confusing.


Could probably be fixed by passing false as a second parameter to the
class_exists.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l