[Bug 26910] PHP/JS email validation unstable in 1.17 branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=26910 Nux e...@wp.pl changed: What|Removed |Added CC||e...@wp.pl --- Comment #1 from Nux e...@wp.pl 2011-01-25 22:26:05 UTC --- The variable rfc5322_atext contains ...+-/ This doesn't seem right (RegExp would also catch ,) and so - should be backslashed (double backslashed). Also I think that var keyword should be placed before rfc1034_ldh_str as the comment above it makes the code less clear. And a minor code cleanup - change this: '[' + rfc5322_atext + '\\.' + ']' + '+' to this (shorter and clearer): '[' + rfc5322_atext + '\\.]+' BTW there is an error message here: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki.util/mediawiki.util.js?view=markuppathrev=79924 Maybe this is because of the the character next to } in rfc5322_atext which I see as a highlight question mark or as Ń (depending on codepage). Not sure what it is. Probably should be encoded in some other way. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26910] PHP/JS email validation unstable in 1.17 branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=26910 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #2 from Roan Kattouw roan.katt...@gmail.com 2011-01-26 00:27:05 UTC --- (In reply to comment #0) Easy copy paste: 79924 79926 79952 80913 80918 I have tagged them 1.17. All merged now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26910] PHP/JS email validation unstable in 1.17 branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=26910 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26910] PHP/JS email validation unstable in 1.17 branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=26910 --- Comment #3 from Nux e...@wp.pl 2011-01-26 00:59:41 UTC --- Hm... I thought this was to be reviewed. Nevermind. Just in case you would be interested I moved my comments here: Bug 26948. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26910] PHP/JS email validation unstable in 1.17 branch
https://bugzilla.wikimedia.org/show_bug.cgi?id=26910 Ashar Voultoiz has...@free.fr changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #4 from Ashar Voultoiz has...@free.fr 2011-01-26 07:18:47 UTC --- Thanks Roan. I am closing this merge request and subscribing to Nux's bug -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
