[Bug 27238] Regression: change to the redirection of the iPad users
https://bugzilla.wikimedia.org/show_bug.cgi?id=27238 Brion Vibber changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #8 from Brion Vibber 2011-02-08 11:22:32 UTC --- Comment and reopen belonged on bug 27245. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27238] Regression: change to the redirection of the iPad users
https://bugzilla.wikimedia.org/show_bug.cgi?id=27238 Brion Vibber changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #7 from Brion Vibber 2011-02-08 11:20:49 UTC --- See my comments on code review for r81714; this regex is super unclear as to its purpose and is likely very fragile, and the test cases don't appear to include any cases for the Android 3.0 tablets that the change is meant to address. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27238] Regression: change to the redirection of the iPad users
https://bugzilla.wikimedia.org/show_bug.cgi?id=27238 Hampton Catlin changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #6 from Hampton Catlin 2011-02-08 11:13:10 UTC --- Ok, so lets go through these. The test cases were not supposed to be deleted. I *thought* I moved them. But, since I haven't used SVN in any capacity in 10 years, I f*cked it up. Sorry! Should be closed in r81714 with more tests and a tweaked UA regex. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27238] Regression: change to the redirection of the iPad users
https://bugzilla.wikimedia.org/show_bug.cgi?id=27238 --- Comment #5 from Brion Vibber 2011-02-08 09:53:32 UTC --- Broke the android issue out to bug 27245 for a fresh fix. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27238] Regression: change to the redirection of the iPad users
https://bugzilla.wikimedia.org/show_bug.cgi?id=27238 --- Comment #4 from Reedy 2011-02-08 09:52:14 UTC --- (In reply to comment #3) > I've reverted the change in r81700; the test cases were mysteriously deleted > previously, so that's all of r81128 now reverted on trunk. > > It looks like it was *intended* to fix Android tablets to not redirect to the > mobile site, but apparently did so by removing any checks for Android, and > replacing the Android, iPhone, and iPod checks with a "Mobile Safari" check > which of course slapped the iPad across the head, exactly what shouldn't be > done for a tablet. > > A proper fix for that other problem would still need to be made. Test cases were deleted by hampton as an easier way for tomasz to commit it live (not having to add a directory). However, we didn't work out why the hell he didn't just svn move them up a level into the main directory -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27238] Regression: change to the redirection of the iPad users
https://bugzilla.wikimedia.org/show_bug.cgi?id=27238 --- Comment #3 from Brion Vibber 2011-02-08 08:31:25 UTC --- I've reverted the change in r81700; the test cases were mysteriously deleted previously, so that's all of r81128 now reverted on trunk. It looks like it was *intended* to fix Android tablets to not redirect to the mobile site, but apparently did so by removing any checks for Android, and replacing the Android, iPhone, and iPod checks with a "Mobile Safari" check which of course slapped the iPad across the head, exactly what shouldn't be done for a tablet. A proper fix for that other problem would still need to be made. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27238] Regression: change to the redirection of the iPad users
https://bugzilla.wikimedia.org/show_bug.cgi?id=27238 Brion Vibber changed: What|Removed |Added Summary|Change to the redirection |Regression: change to the |of the iPad users? |redirection of the iPad ||users Severity|enhancement |normal --- Comment #2 from Brion Vibber 2011-02-08 08:20:17 UTC --- Culprit is r81128 (was merged to 1.16wmf4 in r67681). It hasn't been merged to 1.17wmf1, so this behavior may disappear from production shortly. Still needs to be fixed on trunk. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
